Skip to content

Module files action group is accessible from the theme context #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bohdan-harniuk opened this issue Feb 18, 2022 · 5 comments
Closed

Module files action group is accessible from the theme context #1010

bohdan-harniuk opened this issue Feb 18, 2022 · 5 comments

Comments

@bohdan-harniuk
Copy link
Collaborator

bohdan-harniuk commented Feb 18, 2022

Describe the bug (*)

We can access the Module files action group from the theme context.

To Reproduce (*)

Steps to reproduce the behavior:

  1. Go to any custom theme in the app/design/
  2. Click on the any folder in the theme or even outer of it
  3. The New Magento 2 module action is available here
  4. Create new module in the theme
  5. All context actions are available here

Expected behavior (*)

  • There is no possibility to create a new Magento 2 module outer of the app/code directory.
  • There is no possibility to see any context actions in the module inside a theme (because such modules should not be there)

Screenshots

Screenshot 2022-02-18 at 16 56 27

Screenshot 2022-02-18 at 16 58 18

Please complete the following information: (*)

  • OS: Any
  • PhpStorm/Intellij version: Any
  • Plugin Version: Any

Additional context

@Iamwade, thank you for reporting this issue.

@m2-assistant
Copy link

m2-assistant bot commented Feb 18, 2022

Hi @bohdan-harniuk. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.

Add a comment to assign the issue: @magento I am working on this


@Iamwade
Copy link
Collaborator

Iamwade commented Feb 21, 2022

@magento I am working on this

@doninAtwix
Copy link
Contributor

@magento I am working on this

@doninAtwix
Copy link
Contributor

Hi @bohdan-harniuk .
The code for displaying the menu Module file and groups of xml files was compared. The logic of checking the context menu called in the module and checking the visibility was borrowed. It was not possible to restrict the display for subfolders in the module.

Thanks

@bohdan-harniuk
Copy link
Collaborator Author

The first expected behaviour condition (there is no possibility to create a new Magento 2 module outer of the app/code directory.) has been already fixed in the #633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants