#9347: Zend feed refactoring

 - Fixes based on static tests

Author: ishakhsuvarov

app/code/Magento/Rss/Test/Unit/Model/RssTest.php

@@ -43,7 +43,7 @@ class RssTest extends \PHPUnit\Framework\TestCase
     <link>http://magento.com/rss/link</link>
     <description><![CDATA[Feed Description]]></description>
     <pubDate>Sat, 22 Apr 2017 13:21:12 +0200</pubDate>
-    <generator>Zend_Feed</generator>
+    <generator>Zend\Feed</generator>
     <docs>http://blogs.law.harvard.edu/tech/rss</docs>
     <item>
       <title><![CDATA[Feed 1 Title]]></title>

lib/internal/Magento/Framework/App/Feed.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\App;
 
 use Zend\Feed\Writer\FeedFactory;

lib/internal/Magento/Framework/App/FeedFactory.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\App;
 
 use Magento\Framework\ObjectManagerInterface;
@@ -46,7 +48,7 @@ public function __construct(
     /**
      * {@inheritdoc}
      */
-    public function create(array $data, $format = FeedFactoryInterface::FORMAT_RSS) : FeedInterface
+    public function create(array $data, string $format = FeedFactoryInterface::FORMAT_RSS) : FeedInterface
     {
         if (!isset($this->formats[$format])) {
             throw new \Magento\Framework\Exception\InputException(

lib/internal/Magento/Framework/App/FeedFactoryInterface.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\App;
 
 /**
@@ -24,5 +26,5 @@ interface FeedFactoryInterface
      * @param string $format
      * @return FeedInterface
      */
-    public function create(array $data, $format = self::FORMAT_RSS) : FeedInterface;
+    public function create(array $data, string $format = self::FORMAT_RSS) : FeedInterface;
 }

lib/internal/Magento/Framework/App/FeedInterface.php

@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\App;
 
 /**