Prevent side effect on category objects store_id and url_key on save

magento · May 8, 2020 · 7bd5e25 · 7bd5e25
1 parent 6b6f428
commit 7bd5e25
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGenerator.php b/app/code/Magento/CatalogUrlRewrite/Model/CategoryUrlRewriteGenerator.php
@@ -124,6 +124,9 @@ protected function generateForGlobalScope(
         $mergeDataProvider = clone $this->mergeDataProviderPrototype;
         $categoryId = $category->getId();
         foreach ($category->getStoreIds() as $storeId) {
+            if ($storeId !== Store::DEFAULT_STORE_ID) {
+                $category = clone $category; // prevent undesired side effects on original object
+            }
             $category->setStoreId($storeId);
             if (!$this->isGlobalScope($storeId)
                 && $this->isOverrideUrlsForStore($storeId, $categoryId, $overrideStoreUrls)