MAGETWO-52000: [Github][PR]impossible to see what is wrong with cron - unhelpful error message #3189

- fixes for QA issues.

Author: mazhalai

setup/src/Magento/Setup/Model/Cron/JobFactory.php

@@ -134,7 +134,14 @@ public function create($name, array $params = [])
                 break;
             case self::JOB_ENABLE_CACHE:
                 $cmd = $objectManager->get('Magento\Backend\Console\Command\CacheEnableCommand');
-                return new JobSetCache($cmd, $objectManagerProvider, $multipleStreamOutput, $cronStatus, $name);
+                return new JobSetCache(
+                    $cmd,
+                    $objectManagerProvider,
+                    $multipleStreamOutput,
+                    $cronStatus,
+                    $name,
+                    $params
+                );
                 break;
             case self::JOB_DISABLE_CACHE:
                 $cmd = $objectManager->get('Magento\Backend\Console\Command\CacheDisableCommand');

setup/src/Magento/Setup/Model/Cron/JobSetCache.php

@@ -5,6 +5,7 @@
  */
 namespace Magento\Setup\Model\Cron;
 
+use Magento\Backend\Console\Command\AbstractCacheManageCommand;
 use Symfony\Component\Console\Input\ArrayInput;
 
 class JobSetCache extends AbstractJob
@@ -54,8 +55,11 @@ public function __construct(
     public function execute()
     {
         try {
-            $this->params['command'] = $this->command->getName();
-            $this->command->run(new ArrayInput($this->params), $this->output);
+            if (!empty($this->params)) {
+                $arguments[AbstractCacheManageCommand::INPUT_KEY_TYPES] = explode(' ', $this->params[0]);
+            }
+            $arguments['command'] = $this->command->getName();
+            $this->command->run(new ArrayInput($arguments), $this->output);
         } catch (\Exception $e) {
             $this->status->toggleUpdateError(true);
             throw new \RuntimeException(sprintf('Could not complete %s successfully: %s', $this, $e->getMessage()));

setup/src/Magento/Setup/Model/UpdaterTaskCreator.php

@@ -142,7 +142,7 @@ public function createUpdaterTasks(array $postPayload)
 
         $enabledCaches = [];
         foreach ($cacheStatus as $cacheName => $value) {
-            if ($value) {
+            if ($value === 1) {
                 $enabledCaches[] = $cacheName;
             }
         }