Skip to content

Commit bed17e0

Browse files
🔃 [EngCom] Public Pull Requests - 2.3-develop
Accepted Public Pull Requests: - #15360: 15210-Fixed product tier pricing pagination issue in admin (by @saravananvelu) - #15489: Duplicate array keys (by @lfluvisotto) - #15492: Return tag misspelled (by @lfluvisotto) Fixed GitHub Issues: - #15210: Advanced pricing pagination issue (reported by @dryadav) has been fixed in #15360 by @saravananvelu in 2.3-develop branch Related commits: 1. cad44a3 2. 560aa38 3. 8a8ed66 4. ba6bf77 5. 6de6006 6. ec3eb1a 7. 75960ce
2 parents 7532620 + 1f1e1a0 commit bed17e0

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

app/code/Magento/Catalog/Test/Unit/Model/ProductRepositoryTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1336,7 +1336,6 @@ public function testSaveExistingWithMediaGalleryEntries()
13361336

13371337
$expectedResult = [
13381338
[
1339-
'value_id' => 5,
13401339
'value_id' => 5,
13411340
"label" => "new_label_text",
13421341
'file' => 'filename1',

app/code/Magento/ReleaseNotification/Ui/Renderer/NotificationRenderer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ private function buildFooter(array $footer)
174174
* correct HTML format.
175175
*
176176
* @param string $content
177-
* @returns string
177+
* @return string
178178
*/
179179
private function formatContentWithLinks($content)
180180
{

app/code/Magento/Ui/view/base/web/js/dynamic-rows/dynamic-rows.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -721,6 +721,8 @@ define([
721721
* @param {Number} page - current page
722722
*/
723723
changePage: function (page) {
724+
this.clear();
725+
724726
if (page === 1 && !this.recordData().length) {
725727
return false;
726728
}
@@ -762,15 +764,13 @@ define([
762764
* Change page to next
763765
*/
764766
nextPage: function () {
765-
this.clear();
766767
this.currentPage(this.currentPage() + 1);
767768
},
768769

769770
/**
770771
* Change page to previous
771772
*/
772773
previousPage: function () {
773-
this.clear();
774774
this.currentPage(this.currentPage() - 1);
775775
},
776776

0 commit comments

Comments
 (0)