Skip to content

Commit e17a3e7

Browse files
#32619: Underscores not allowed in module names in \Magento\Framework\App\Utility\Files::accumulateThemeStaticFiles.
1 parent a3b124a commit e17a3e7

File tree

4 files changed

+31
-0
lines changed

4 files changed

+31
-0
lines changed

dev/tests/integration/testsuite/Magento/Framework/App/Utility/FilesTest.php

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,4 +159,16 @@ public function testReadLists()
159159
}
160160
$this->assertSame($expected, $actual);
161161
}
162+
163+
/**
164+
* Tests if underscores are allowed in extended static files in theme.
165+
*
166+
* @magentoComponentsDir Magento/Framework/App/Utility/_files/design
167+
* @magentoAppIsolation enabled
168+
* @magentoDbIsolation enabled
169+
*/
170+
public function testAllowUnderscoreInExtendedFiles()
171+
{
172+
$this->model->getStaticPreProcessingFiles('*.less');
173+
}
162174
}

dev/tests/integration/testsuite/Magento/Framework/App/Utility/_files/design/frontend/Test/default/Module_Third_Party/web/css/source/_module.less

Whitespace-only changes.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
7+
use Magento\Framework\Component\ComponentRegistrar;
8+
9+
ComponentRegistrar::register(ComponentRegistrar::THEME, 'frontend/FrameworkUtilityTest/default', __DIR__);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Config/etc/theme.xsd">
9+
<title>Test Default</title>
10+
</theme>

0 commit comments

Comments
 (0)