Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup:config:set --key append instead of replace #11089

Closed
ju5t opened this issue Sep 27, 2017 · 7 comments
Closed

setup:config:set --key append instead of replace #11089

ju5t opened this issue Sep 27, 2017 · 7 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@ju5t
Copy link

ju5t commented Sep 27, 2017

Preconditions

This particular container/server runs PHP 7.0.23 and Magento 2.1.9 which was downloaded from the website.

Steps to reproduce

# bin/magento setup:config:set --key=test
Overwrite the existing configuration for key?[Y/n]Y
You saved the new configuration.

Expected result

To replace the value in crypt => array('key' => '').

Actual result

It appends the value to crypt => array('key' => ''). This will result in:

  'crypt' =>
  array (
    'key' => 'test
test',
  )
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Sep 27, 2017
@magento-engcom-team
Copy link
Contributor

@ju5t, thank you for your report.
We've created internal ticket(s) MAGETWO-80169 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Sep 27, 2017
@adioe3
Copy link

adioe3 commented Oct 1, 2017

I'd like to take this one

@renttek
Copy link

renttek commented Oct 4, 2017

Hi, there is already an "accepted" pull request from me for this issue. You can see the link right above your comment.
(I think, the existing pull requests are pretty bad to spot. Solved an Issue with existing PR last week too)

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-80514

@okorshenko
Copy link
Contributor

Hi @ju5t the issue has been fixed and delivered to 2.2-develop branch (#11155) and will be available with release 2.2.1

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 11, 2017
@ju5t
Copy link
Author

ju5t commented Oct 12, 2017

Hi @okobchenko. Awesome work everyone. I'm impressed by the speed at which this was resolved.

@sidolov
Copy link
Contributor

sidolov commented Mar 4, 2018

Hi @ju5t. Thank you for your report.
The issue has been fixed in #13630 by @nmalevanec in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

7 participants