Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't close full screen gallery on iOS devices #13226

Closed
torhoehn opened this issue Jan 16, 2018 · 6 comments
Closed

Can't close full screen gallery on iOS devices #13226

torhoehn opened this issue Jan 16, 2018 · 6 comments
Assignees
Labels
Event: balance-cd Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@torhoehn
Copy link
Contributor

It's not possible to close the full screen image gallery on iOS devices. Maybe other devices are affected.
I found some other issues or comment regarding this topic, but they've been closed by mistake.
#12185
#12490 (comment)
https://magento.stackexchange.com/questions/207194/magento-2-product-gallery-doesnt-close-on-iphone

Preconditions

  1. Magento 2.2-develop
  2. PHP 7.0.22
  3. MySQL 5.6.35

Steps to reproduce

  1. Start Apple Simulator (https://developer.apple.com/library/content/documentation/IDEs/Conceptual/iOS_Simulator_Guide/Introduction/Introduction.html)
  2. Run Safari and open any product detail page
  3. Tap on the image to open the product image in fullscreen mode
  4. Tap on the close button in the upper right corner

Expected result

  1. Gallery should be closed
  2. Product detail page should be visible again

Actual result

  1. Gallery doesn't disappear
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 16, 2018
@magento-engcom-team
Copy link
Contributor

@torhoehn, thank you for your report.
We've acknowledged the issue and added to our backlog.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Mar 2, 2018
@pavelshulgabi
Copy link

I'm working on #cd-balance

@pavelshulgabi
Copy link

The reported issue was extensively tested on vanilla Magento versions 2.2.4, 2.2.5 and 2.2-develop (2.2.6).
As per investigation, the issue is resolved. The fix was to explicitly trigger required DOM event for mobile devices:
https://github.com/magento/magento2/blob/2.2.4/lib/web/fotorama/fotorama.js#L1221

The verification was conducted on a real device, for more information please refer to the screen capture video below:
https://drive.google.com/open?id=1S5qGgfbG3fw4SB1jvqGzn-Zpe1-4g1EL

In case if anyone is still encountering the issue described in this thread feel free to reopen the it.

@ghost
Copy link

ghost commented Jul 9, 2019

I'm not sure how to reopen the issue, but it is still there in production mode when opting to minify js files. It seems like the fix was not put into the minified version of the script.

@torhoehn
Copy link
Contributor Author

torhoehn commented Jul 9, 2019

@shilpambb Minified version of fotorama was removed in #22082.

@ghost
Copy link

ghost commented Jul 9, 2019

@torhoehn thanks for the update. Looks like it didn't make it into 2.2.9. I guess it will make it into the next release for 2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event: balance-cd Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

4 participants