Configurable product price options by store #13933
Conversation
| } | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function getProducts(ProductInterface $product) | ||
| { | ||
| if (!isset($this->linkedProductMap[$product->getId()])) { | ||
| $key = $this->storeManager->getStore()->getId() . '-' . $product->getId(); |
There was a problem hiding this comment.
Price of product in Magento can be modified only on website level, so better use website id here
There was a problem hiding this comment.
You are right, prices and tax class id can be modified only on website level, but scope for 'Special Price From Date' and 'Special Price To Date' can be changed from admin panel http://prntscr.com/in1pba . So that attribute can affect results. That's why i decided to use store id.
There was a problem hiding this comment.
I believe that scope for 'Special Price From Date' is wrong. All price related option should be a website or global level.
There was a problem hiding this comment.
You are totally right, but we have what we have and that works fine. If we will change for website level - in environmen emulation we will get different results than on real website. That why i propose to keep it without changes.
I tried to create 3 products: 2 simple, 1 configurable and set 'Special Price From Date' for store view level.
Results:
Default store view: http://prntscr.com/ipevz0
Second store view: http://prntscr.com/ipewma
Product settings:
http://prntscr.com/ipex7e (Second store view)
http://prntscr.com/ipexld (all stores and default store view is without overrides)
There was a problem hiding this comment.
On my opinion, store view level caching shouldn't affect performance.
If i remember correctly 'Special Price From Date' attribute doesn't exist in price index, that why it could be in store view level and works correctly.
There was a problem hiding this comment.
The last word is yours ;)
There was a problem hiding this comment.
In any case, your solution fixes the problem and improves the system, and my comment is just a suggestion for improvement, you can ignore it as a minor
… fixed in Magento 2.2.8 / 2.3.1 - see magento/magento2#13933
Added compatability of
LowestPriceOptionsProviderclass and environmen emulation fucntionality.Updated
linkedProductMapproperty in lowest price options provider to cache options by store and product id.Description
Some modules (e.g. Abandoned Cart, Algolia Search etc.) use store emulation functionality (
\Magento\Store\Model\App\Emulation::startEnvironmentEmulation) to get product info (including configurable product price) for each store. UnfortunatelyLowestPriceOptionsProviderclass save linked products collection at the$linkedProductMapproperty based on requested product id only. That is why configurable product price will be the same for other stores after first emulation.Contribution checklist
Forwardport for: #13808