Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing @tab-content__border variable has no effect in Blank theme #14999

Closed
denistrator opened this issue May 4, 2018 · 4 comments · Fixed by #15916
Closed

Changing @tab-content__border variable has no effect in Blank theme #14999

denistrator opened this issue May 4, 2018 · 4 comments · Fixed by #15916
Assignees
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@denistrator
Copy link

denistrator commented May 4, 2018

Preconditions

Any Magento 2
FE theme inherited from Magento/Blank

Steps to reproduce

In Custom/theme/web/css/source/_theme.less set less variables to:
@tab-content__border-top-status: false;
@tab-content__border: 1px solid #000;

Expected result

Tabs content has border

Actual result

Tabs content has no border

What causes the issue

web/css/source/_sections.less calls .lib-data-tabs() mixin with @_tab-content-border-top-status: true argument, so @tab-content__border-top-status variable isn't used in .lib-data-tabs()

Solution

  1. Remove @_tab-content-border-top-status: true argument in web/css/source/_sections.less (as it's done in Magento/Luma);
  2. Add @tab-content__border-top-status: true in web/css/source/_variables.less

Workaround

Create Custom/theme/web/css/source/_sections_extend.less with:

.media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__m) {
    .product.data.items {
        > .item.content {
            ._lib-tab-content-border(
                @_tab-content-border-top-status: @tab-content__border-top-status
            );
        }
    }
}
@hitesh-wagento
Copy link
Contributor

I am working on this

@sidolov
Copy link
Contributor

sidolov commented Jun 13, 2018

Hi @denistrator. Thank you for your report.
The issue has been fixed in #15917 by @hitesh-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@sidolov sidolov added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jun 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @denistrator. Thank you for your report.
The issue has been fixed in #15916 by @hitesh-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added Fixed in 2.3.x The issue has been fixed in 2.3 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line labels Jun 13, 2018
@magento-engcom-team
Copy link
Contributor

Hi @denistrator. Thank you for your report.
The issue has been fixed in #15914 by @hitesh-wagento in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
4 participants