Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor javascript code of button split widget call js component #15354

Closed
amittiwari024 opened this issue May 19, 2018 · 4 comments
Closed

Refactor javascript code of button split widget call js component #15354

amittiwari024 opened this issue May 19, 2018 · 4 comments
Assignees
@amittiwari024
Labels
Event: dmcdindia Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@amittiwari024
Copy link
Contributor

Refactor javascript code of button split widgete

Preconditions

  1. Need to refactor template file and need to call js component which is already created
    magento2\app\code\Magento\Ui\view\base\web\js\grid\controls\button\split.js

Steps to reproduce

  1. N/A

Expected result

1.N/A

Actual result

1.N/A
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 19, 2018
@amittiwari024 amittiwari024 mentioned this issue May 19, 2018
Merged
4 tasks
@amittiwari024 amittiwari024 self-assigned this May 19, 2018
@amittiwari024
Copy link
Contributor Author

Issue is fixed: #15351

@magento-engcom-team
Copy link
Contributor

Hi @amittiwari024. Thank you for your report.
The issue has been fixed in #15351 by @amittiwari024 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label May 22, 2018
This was referenced Jun 4, 2018
Merged
Merged
Merged
@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 5, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 5, 2018

Hi @amittiwari024. Thank you for your report.
The issue has been fixed in #15731 by @vijay-wagento in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team
Copy link
Contributor

Hi @amittiwari024. Thank you for your report.
The issue has been fixed in #15736 by @vijay-wagento in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.15 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amittiwari024 amittiwari024

Labels
Event: dmcdindia Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sidolov @magento-engcom-team @amittiwari024