Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New order notification is not sent to the admin #16203

Closed
bnymn opened this issue Jun 17, 2018 · 19 comments
Closed

New order notification is not sent to the admin #16203

bnymn opened this issue Jun 17, 2018 · 19 comments
Labels
Component: Email Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@bnymn
Copy link
Contributor

bnymn commented Jun 17, 2018

When a customer places an order, (s)he receives an order confirmation email but admin does not receive any notification.

I have traced back the error to this file (vendor/magento/module-sales/Model/Order/Email/Sender.php:84)

screenshot from 2018-06-17 16-24-56

It throws an exception with the following message "From Header set twice".

Preconditions

  1. PHP 7.1.18
  2. MySQL 5.7.22
  3. Magento 2.2.4

Steps to reproduce

  1. Login as admin.
  2. Go to Stores -> Configuration -> Sales -> Sales Emails.
  3. Go to Order section.
  4. Make sure it is enabled.
  5. Add your email into the field Send Order Email Copy To.
  6. "Send Order Email Copy Method" to "Separate Email".
  7. Go to your Magento store.
  8. Login as a customer.
  9. Make a new order.

Expected result

  1. The customer should receive the order confirmation email.
  2. The email address in the Magento admin which we have just added should also receive a copy.

Actual result

  1. The customer receives order confirmatio email.
  2. But admin is not notified, nor the copies are sent.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jun 17, 2018
@bnymn
Copy link
Contributor Author

bnymn commented Jun 17, 2018

I think the following issue is related with this one. #16165

@kkrieger85 kkrieger85 added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Jun 19, 2018
@gwharton
Copy link
Contributor

This is where the issue was first created. #11740

@ghost ghost self-assigned this Jul 5, 2018
@ghost ghost added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Fixed in 2.1.x The issue has been fixed in 2.1 release line Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Jul 5, 2018
@ghost
Copy link

ghost commented Jul 5, 2018

@bnymn, thank you for your report.
We've acknowledged the issue and added to our backlog.

@gwharton
Copy link
Contributor

gwharton commented Jul 5, 2018

PR #16461 is awaiting review and will fix this issue.

@ghost ghost removed their assignment Jul 12, 2018
@ghost ghost added the Component: Email label Jul 19, 2018
@RishabhRkRai
Copy link

I also have the same issue on Magento 2.2.5

@Mart-ASE
Copy link

I also encountered this. how can i fix it? im using Magento ver. 1.7.0.2

@tanolalano
Copy link

tanolalano commented Oct 31, 2018

Same issue on magento 2.2.6
php 7.1.22
MySQL 5.7.22

Order mail was sent but marked as (The order confirmation email is not sent) in admin detail order.
No mail was sent to Addresses set on "Send Order Email Copy To" with "Separate Email" settings.
This issue is present on all payments method.
No error on log nor in Apache error_log

@gwharton
Copy link
Contributor

PR #18472 is the fix. Just waiting to be merged.

@ghost ghost self-assigned this Nov 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost
Copy link

ghost commented Nov 21, 2018

Hi @bnymn The issue was re-tested and we can confirm that it was fixed on the 2.3 release branch. We closing this issue as fixed due to upcoming 2.3 release that will be available soon.

@ghost ghost closed this as completed Nov 21, 2018
@gwharton
Copy link
Contributor

I really don't agree with this new process to be honest. The decision to not fix any bugs on 2.2 unless they are also present in 2.3 seems a strange one!

@ghost
Copy link

ghost commented Nov 21, 2018

@gwharton I'm tested it now on 2.2-develop, i'm not able to reproduce this on 2.2-develop.

@gwharton
Copy link
Contributor

Looks like it may have been fixed in MAGETWO-91477

9a7c9e5#diff-dfb3ee5a7f863458afea75f5524cd2e5

@ankurverma5540
Copy link

ankurverma5540 commented Nov 30, 2018

I am facing the same issue. What need to done to fix this issue? I am using Magento 2.2.5 and i don't have Magento folder in lib/internal. I created that folder place files according this commit
9a7c9e5#diff-dfb3ee5a7f863458afea75f5524cd2e5
But still not working.

@donovandb
Copy link

donovandb commented Dec 10, 2018

Magento 2.2.1
Just adding that I did not have this problem until enabling authorize.net.
We had "bluepay" up until Nov. "Send Order Email Copy To" emails were working fine. We switched to Authorize.net and now they are no longer working. Hope that helps.

@coatesjonathan
Copy link

Hi, how do I get this merged into 2.2.5? I need this fixed

@LiamKarlMitchell
Copy link

How to backport to 2.2.5 please, has someone got an extension plugin for this, it's kind of an important functionality to let orders email know of orders...

@helefa
Copy link

helefa commented May 29, 2019

I'm having this issue in 2.2.4 and cannot upgrade to 2.3. Is there a fix for my version?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Email Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests