Skip to content

Valid PHP class names containing number not accepted in indexer.xsd and mview.xsd schemas #17494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mlindholm opened this issue Aug 10, 2018 · 2 comments
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@mlindholm
Copy link

Preconditions

  1. Magento 2.2.4
  2. PHP 7.1
  3. MySQL 5.6

Steps to reproduce

  1. Create indexer class with number on the class name. Example Vendor\ModuleB2B\Model\Indexer
  2. Create table moduleb2b_index table.
  3. Create indexer configuration for the indexer class.
  4. Create mview configuration for indexer class and table.

Expected result

  1. indexer.xml should be accepted as valid configuration as the class name is valid php class name.
  2. mview.xml should be accepted as valid configuration as the class and table names are valid.

Actual result

  1. According to indexer.xsd the class name is not valid because it contains number.
  2. According to mview.xsd the class name and the table name are not valid because they contain number.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Tuuhea. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@Tuuhea do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost ghost self-assigned this Aug 10, 2018
@ghost
Copy link

ghost commented Aug 10, 2018

Duplicate of #9985

@ghost ghost marked this as a duplicate of #9985 Aug 10, 2018
@ghost ghost closed this as completed Aug 10, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

2 participants