Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Type ID at Join #18131

Closed
akimatze opened this issue Sep 19, 2018 · 7 comments
Closed

Entity Type ID at Join #18131

akimatze opened this issue Sep 19, 2018 · 7 comments
Assignees
Labels
Component: Eav Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@akimatze
Copy link

akimatze commented Sep 19, 2018

Preconditions

  1. Magento EE 2.2.5
  2. MySQL 5.7, PHP 7.1.14

Steps to reproduce

  1. Create new Entity Type with InstallData Script. Use eav_entity table as entity table with some random attributes.
  2. Create Default EAV Model, ResourceModel and Collection
  3. Use collection, addFieldToSelect of one of the attributes and load them.

Expected result

  1. Entries with added attribute

Actual result

  1. Integrity constraint violation: 1052 Column 'entity_type_id' in where clause is ambiguous, query was: SELECT e.entity_id, t_d.attribute_id, t_d.value FROM eav_entity AS e INNER JOIN eav_entity_varchar AS t_d ON e.entity_id = t_d.entity_id WHERE ( e.entity_id IN (1)) AND (t_d.attribute_id IN ('464')) AND (entity_type_id =12)

Quick fix:

  1. Magento\Eav\Model\Entity\Collection\AbstractCollection.php ~line 1235
  2. Add to $select->where(..) statement: 'e.entity_type_id =?' instead of 'entity_type_id'
@magento-engcom-team
Copy link
Contributor

Hi @akimatze. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@akimatze do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 19, 2018
@akimatze akimatze changed the title Entity Type ID at oin Entity Type ID at Join Sep 19, 2018
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 19, 2018
@ghost ghost self-assigned this Sep 19, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 19, 2018

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label G1 Passed will be added to the issue automatically. Please, edit issue description if needed, until label G1 Passed appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add G2 Passed label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label acknowledged once verification is complete.

  • 7. Make sure that automatic system confirms that report is acknowledged.

@ghost ghost added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 19, 2018
@ghost
Copy link

ghost commented Sep 19, 2018

Hi @akimatze this is duplicate for this -> #17863
The same logics affcted, to the query.
And this may be fixed with this pr -> #17864
If you like to update this, please reopen the issue.

@ghost ghost closed this as completed Sep 19, 2018
@ghost ghost added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 19, 2018
@ghost ghost reopened this Sep 19, 2018
@ghost ghost added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Eav Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Sep 19, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-95102, MAGETWO-95103 were created

@ghost
Copy link

ghost commented Sep 19, 2018

@akimatze, thank you for your report.
We've acknowledge the issue and added to our backlog.

@ghost ghost removed their assignment Sep 19, 2018
@strell strell self-assigned this Oct 6, 2018
@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Oct 16, 2018
@sidolov
Copy link
Contributor

sidolov commented Oct 16, 2018

Hi @akimatze. Thank you for your report.
The issue has been fixed in #18437 by @strell in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @akimatze. Thank you for your report.
The issue has been fixed in #18658 by @gelanivishal in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Eav Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants