Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WYSIWYG-Editor Insert Image-Popup is not working correctly with multiple WYSIWYG-Editors on page #18548

Closed
4ctobias opened this issue Oct 12, 2018 · 15 comments
Assignees
Labels
Component: Framework/Wysiwyg Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@4ctobias
Copy link
Contributor

4ctobias commented Oct 12, 2018

Preconditions

Two or more wysiwyg-editors on the catalog product edit page, only the first one is in wysiwyg-mode - at least the last editor in the same "block" (eg. content) is hidden/in plain text-area-mode.

Tested with Magento 2.2.6

Steps to reproduce

  1. Open the catalog product edit page
  2. Open the "content" area"
  3. Enable the WYSIWYG-Mode for the Description
  4. Hide the last editor in the same area (eg. Short Description or ItemDescV)
  5. Click on Insert Image in the Description Editor
  6. Click on the browse-icon for the Image URL
  7. Select a image from the media browser
  8. Click on insert file

Expected result

  1. The image URL is pushed into the field "Image URL" within the Insert/Edit Image dialog
  2. No HTML-Code is inserted yet in the WYSIWYG-Editor

Actual result

  1. The Image URL field stays empty
  2. An img-Tag is inserted in the non-editor of the last editor-element with the selected image URL. This happens only if the last editor in the same area is hidden.
@magento-engcom-team
Copy link
Contributor

Hi @4ctobias. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@4ctobias do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 12, 2018
@4ctobias
Copy link
Contributor Author

@magento-engcom-team give me 2.2.6 instance

@magento-engcom-team
Copy link
Contributor

Hi @4ctobias. Thank you for your request. I'm working on Magento 2.2.6 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @4ctobias, here is your Magento instance.
Admin access: https://i-18548-2-2-6.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@4ctobias
Copy link
Contributor Author

@magento-engcom-team Yes, I was able to reproduce the issue on the vanilla Magento instance.

@ghost ghost self-assigned this Nov 23, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 23, 2018

Hi @engcom-backlog-andrii. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Nov 23, 2018
@ghost
Copy link

ghost commented Nov 23, 2018

Hi @4ctobias. Thanks for the report. This problem has already been fixed on 2.3 develop

@ghost ghost closed this as completed Nov 23, 2018
@ghost ghost removed their assignment Nov 23, 2018
@Ctucker9233
Copy link

@engcom-backlog-tomash This issue was reported against 2.2. Is there a backport?

@Ctucker9233 Ctucker9233 reopened this Apr 2, 2019
@ghost ghost self-assigned this Apr 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 3, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost assigned Nazar65 Apr 5, 2019
@ghost ghost added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Apr 5, 2019
@ghost ghost removed their assignment Apr 5, 2019
@rogyar
Copy link
Contributor

rogyar commented Apr 5, 2019

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: https://i-18548-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar rogyar added Component: Framework/Wysiwyg Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 5, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @rogyar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99072 were created

Issue Available: @rogyar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @4ctobias. Thank you for your report.
The issue has been fixed in #22174 by @Nazar65 in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Apr 17, 2019
@VladimirZaets
Copy link
Contributor

Hi @4ctobias. Thank you for your report.
The issue has been fixed in #25556 by @engcom-Golf in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Wysiwyg Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests

6 participants