-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email logo not displaying on Return Emails #19581
Comments
Hi @vivekjha25. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
where @vivekjha25 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @engcom-backlog-nazar. Thank you for working on this issue.
|
@engcom-backlog-nazar Thank you for verifying the issue. Based on the provided information internal tickets |
Hi @maheshWebkul721. Thank you for working on this issue.
|
Do you have a fix for that please? |
OLD COMMENT (See edit section in this answer)Note that i am writing this answer as i am debugging. The same issue persists here without an error notifcation or a apache error or any magento error log. Not even in developer mode. Kind of hard to debug like this ofcourse. It does an ajax call to its own page (theme/design_config/edit) and not to the fileuploader so it makes sense. The ajax call also returns a full page as a response. This form still uses the formElement FileUploader but the it has the new tag of imageUploader under
Change that to
and it works again. The thing is that i think a partial update has been done here. Since 2.3.0 (maybe sooner not sure) there is an imageUploader instead of a fileUploader. We do not use that because it is not compatible with older versions of Magento but you can use it like this (i know this example has a mix of the data/config and settings tags but its the quickest example that i have at the current time)
which will give you the new fancy "select from gallery" function Not sure how to limit the number of images that you can upload in that one since. I tried Anyways i will make a request to make the changes EDITThere is already a patch for this and i missed something References1 : References 2 : |
I am working on this issue at #MM19IN |
1 similar comment
I am working on this issue at #MM19IN |
@chirag-d-wagento thank you for joining. Please accept team invitation here and self-assign the issue. |
Hi @chirag-d-wagento. Thank you for working on this issue.
|
already fixed in 2.2 and 2.3 |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Logo should be displayed as expected.
Actual result (*)
Logo not displaying as expected
The text was updated successfully, but these errors were encountered: