Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\Magento\Framework\Data\Collection::clear does not clear the result for \Magento\Framework\Data\Collection::getSize #21654

Closed
sergeynezbritskiy opened this issue Mar 8, 2019 · 5 comments
Assignees
Labels
Component: Framework/Data Event: kharkivcd19 Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@sergeynezbritskiy
Copy link
Contributor

:

Preconditions (*)

  1. Magento version: 2.2.5 - 2.2.7

Steps to reproduce (*)

  1. Create any instance of \Magento\Framework\Data\Collection. e.g. \Magento\Sales\Model\ResourceModel\Order\Collection
  2. Get count for this collection, call getSize().
  3. Change collection select. e.g. add some additional filter by calling \Magento\Framework\Data\Collection\AbstractDb::addFieldToFilter('entity_id', ['lt' => 1]) or \Magento\Framework\Data\Collection::addFilter
  4. Call \Magento\Framework\Data\Collection::clear() in order to flush previous result
  5. Get count for this collection, call getSize().

Expected result (*)

  1. The result should reflect added filters

Actual result (*)

  1. The result of getSize() method always remains the same after the first call, and ignores clear() method
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 8, 2019

Hi @sergeynezbritskiy. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@sergeynezbritskiy do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 8, 2019
@milindsingh milindsingh added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Mar 10, 2019
@milindsingh milindsingh self-assigned this Mar 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@sergeynezbritskiy
Copy link
Contributor Author

sergeynezbritskiy commented Mar 16, 2019

#kharkivcd19

@sergeynezbritskiy
Copy link
Contributor Author

The issue is fixed now, here is the PR #21670

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sergeynezbritskiy. Thank you for your report.
The issue has been fixed in #21670 by @sergeynezbritskiy in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Data Event: kharkivcd19 Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

4 participants