Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

While add cart price rule from admin click on Condition drop-down arrow direction not change. #22434

Closed
bhavik43 opened this issue Apr 20, 2019 · 20 comments
Closed

While add cart price rule from admin click on Condition drop-down arrow direction not change. #22434

bhavik43 opened this issue Apr 20, 2019 · 20 comments
Assignees
@hiren0241
Labels
Component: Admin Component: Rule Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@bhavik43
Copy link

While add cart price rule from admin click on Condition drop-down arrow direction not change.

Preconditions (*)

Magento 2.3

Steps to reproduce (*)

  1. Go to Admin
  2. Marketing > Cart Price rule
  3. Conditions > Click on +
  4. Open/close and review the Drop-down arrow direction

Expected result (*)

Drop down arrow should be changes as per other drop-downs.

Actual result (*)

issue1
@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2019

Hi @bhavik43. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@bhavik43 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 20, 2019
@krishprakash krishprakash self-assigned this Apr 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2019 •
edited by krishprakash
Loading

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash krishprakash added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Admin Component: Rule labels Apr 20, 2019
@krishprakash
Copy link

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your Magento instance.
Admin access: https://i-22434-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@krishprakash krishprakash added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 20, 2019
@ghost ghost unassigned krishprakash Apr 20, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99316 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 20, 2019
@Karlasa
Copy link
Contributor

Karlasa commented Apr 20, 2019 •
edited
Loading

@krishprakash @bhavik43
Are you sure this is really an issue?
By default conditions dropdown is focused and that's why dropdown arrow is pointed up not down as in default (non focus state) and as in non focus state dropdown will be removed it has no other state to show.

I think this is expected behaviour and should not be counted as issue.

Cheers,

@krishprakash
Copy link

krishprakash commented Apr 20, 2019 •
edited
Loading

@Karlasa Thanks for your response.
It is working fine in Magento 2.2.x and this is not Magento's expected behavior.
You can review in next drop-down behavior which is in Action > Apply while add cart price rule.
I hope you understand.
Thanks.

@Karlasa
Copy link
Contributor

Karlasa commented Apr 20, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your Magento instance.
Admin access: https://i-22434-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@Karlasa
Copy link
Contributor

Karlasa commented Apr 20, 2019

@krishprakash
Thanks for follow up 👍
In this case i would say issue description is bit confusing because seems like conditions dropdown is only one that has focus state reverted arrow and other dropdown elements are missing it and should be fixed instead :)

But yeah issue is there.

@hiren0241 hiren0241 self-assigned this Apr 22, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 22, 2019 •
edited by hiren0241
Loading

Hi @hiren0241. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@hiren0241
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241, here is your Magento instance.
Admin access: https://i-22434-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@hiren0241 hiren0241 mentioned this issue Apr 22, 2019
Merged
4 tasks
@hiren0241
Copy link
Contributor

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241, here is your Magento instance.
Admin access: https://i-22434-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Contributor

Hi @bhavik43. Thank you for your report.
The issue has been fixed in #22456 by @hiren0241 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.2 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hiren0241 hiren0241

Labels
Component: Admin Component: Rule Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Karlasa @magento-engcom-team @hiren0241 @krishprakash @bhavik43