Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 Active categories after flushing Magento cache, while browser tab open on category page #24629

Closed
Jeroen999 opened this issue Sep 17, 2019 · 21 comments
Assignees
Labels
Component: PageCache Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Jeroen999
Copy link

Preconditions (*)

  1. Magento 2.3.2

Steps to reproduce (*)

  1. Open a browser and click on a category in the navigation menu.
  2. Flush Magento cache.
  3. Click on other categories.

Expected result (*)

  1. Only the last clicked category should have the active category css.
  2. If I go to the home page, then there should be no active category.

Actual result (*)

  1. Two categories have the active category css.
  2. When I navigate to the home page, one category still has the active category css.

This doesn't happen when I open another browser after flushing Magento cache or when I flush Magento cache while I'm on the home page.

@m2-assistant
Copy link

m2-assistant bot commented Sep 17, 2019

Hi @Jeroen999. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Jeroen999 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 17, 2019
@engcom-Bravo engcom-Bravo self-assigned this Sep 17, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 17, 2019

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@Jeroen999
Copy link
Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Jeroen999. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Jeroen999, here is your Magento instance.
Admin access: https://i-24629-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@Jeroen999
Copy link
Author

I have created 3 subcategories: Test category 1, Test category 2 and Test category 3. In the attached print screen, you can see that I have reproduced this issue in the develop instance.

2019-09-17 two active categories

@Jeroen999
Copy link
Author

Issue: Confirmed

@engcom-Bravo engcom-Bravo added Component: PageCache Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 17, 2019
@ghost ghost unassigned engcom-Bravo Sep 17, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-20204 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 17, 2019
@kvydiuk kvydiuk self-assigned this Sep 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2019

Hi @kirillvidyuk. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@kvydiuk
Copy link

kvydiuk commented Sep 27, 2019

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @kirillvidyuk. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @kirillvidyuk, here is your Magento instance.
Admin access: https://i-24629-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@kvydiuk
Copy link

kvydiuk commented Sep 27, 2019

Hi @Jeroen999,

I couldn't reproduce issue with Built-In full page cache type.
Even when i enabled Varnish cache, the navigation menu disappeared from page at all.
The menu didn't appear even after an hour for me (expected that ESI ttl=3600 for this block will make the deal):
https://drive.google.com/file/d/1F7doA1e1dPUVwjnHMZBgEQ2rTt7E0LyD/view
Suppose that this could environment specific issue.
And could relates to #3897
All testing was performed on develop instance that was provided by @magento-engcom-team.

Did you have any extra information which would help to reproduce a bug?

Regards,
Kirill

@kvydiuk kvydiuk closed this as completed Sep 27, 2019
@engcom-Bravo
Copy link
Contributor

Yes, @kirillvidyuk, it seems like some silent fix has taken its place. Now I am also not able to reproduce the issue on the develop instance though at that time it was easily reproducible. The issue still persists in 2.3.2 version (just tested) Could You @Jeroen999 also retest it now on the latest develop version. Thank You.

@Jeroen999
Copy link
Author

Okay, give me 2.3-develop instance

@engcom-Bravo
Copy link
Contributor

@magento give me 2.3-develop instance for @Jeroen999

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-Bravo, here is your Magento instance.
Admin access: https://i-24629-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@Jeroen999
Copy link
Author

I can't reproduce this issue in this development version, so I think this issue has been solved.

@engcom-Bravo
Copy link
Contributor

Ok, Thank You all @Jeroen999 , @kirillvidyuk.

@duckchip
Copy link
Contributor

duckchip commented Oct 2, 2019

I think this is related to #24776 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PageCache Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants