Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS validate: show many messsages for Bundle product with checkbox option #27489

Closed
hoangnm89 opened this issue Mar 28, 2020 · 14 comments · Fixed by #27854
Closed

JS validate: show many messsages for Bundle product with checkbox option #27489

hoangnm89 opened this issue Mar 28, 2020 · 14 comments · Fixed by #27854
Assignees
Labels
Area: Frontend Component: Bundle Fixed in 2.4.x The issue has been fixed in 2.4-develop branch improvement Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@hoangnm89
Copy link

Preconditions (*)

  1. Fresh Magento 2.3.4

Steps to reproduce (*)

  1. Create bundle product
  2. Add option. Option Name: anything; Input Type: Checkbox; Required
  3. Add product to Option
  4. Add to cart on store front.
  5. From validate if no option selected.
    image

Expected result (*)

  1. JS should validate and show one error message for Option

Actual result (*)

  1. Show many messages
    image
@m2-assistant
Copy link

m2-assistant bot commented Mar 28, 2020

Hi @hoangnm89. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@hoangnm89 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 28, 2020
@krishprakash krishprakash self-assigned this Mar 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 29, 2020

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your Magento instance.
Admin access: https://i-27489-2-4-develop.instances.magento-community.engineering/admin_db57
Login: 786f1873 Password: 2f3a81208d18
Instance will be terminated in up to 3 hours.

@krishprakash krishprakash added Area: Frontend Component: Bundle Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed improvement Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Mar 29, 2020
@ghost ghost unassigned krishprakash Mar 29, 2020
@ghost ghost removed the Progress: ready for QA label Mar 29, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 29, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-32888 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@krishprakash
Copy link

Here is the similar issue for Wish list #26898

@neerajchand neerajchand self-assigned this Mar 30, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 30, 2020

Hi @neerajchand. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@neerajchand
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @neerajchand. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @neerajchand, here is your Magento instance.
Admin access: https://i-27489-2-4-develop.instances.magento-community.engineering/admin_8bc1
Login: d03137ef Password: a7f8bbd9e907
Instance will be terminated in up to 3 hours.

@ProkopovVitaliy ProkopovVitaliy pinned this issue Apr 13, 2020
@ProkopovVitaliy ProkopovVitaliy unpinned this issue Apr 13, 2020
@ProkopovVitaliy
Copy link
Contributor

@neerajchand Do you still work on it ?

@ProkopovVitaliy
Copy link
Contributor

As there are no activity about 2 weeks i want to continue fix this issue.

@ghost ghost assigned ProkopovVitaliy Apr 14, 2020
@sdzhepa sdzhepa added Triage: Ready for Triage Issue is ready to me triaged with Product Manager Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Apr 30, 2020
@sdzhepa sdzhepa linked a pull request Apr 30, 2020 that will close this issue
4 tasks
@sdzhepa sdzhepa added Triage: Done Has been reviewed and prioritized during Triage with Product Managers and removed Triage: Ready for Triage Issue is ready to me triaged with Product Manager labels Apr 30, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jun 13, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.4 Indicates original Magento version for the Issue report. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Bundle Fixed in 2.4.x The issue has been fixed in 2.4-develop branch improvement Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants