Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tier prices filtering in GraphQl - prices for different customer group but same quantity are not filtered out #29168

Closed
5 tasks
pmarjan opened this issue Jul 16, 2020 · 2 comments · Fixed by #29675
Assignees
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Progress: done Project: GraphQL

Comments

@pmarjan
Copy link
Contributor

pmarjan commented Jul 16, 2020

Execute this query, to search for product that already meets the pre-conditions below

products(search: "[Product-name]"){ items { price_tiers { final_price { currency value } quantity } } }

Preconditions, expected results and actual results, are all based on an example with colliding ALL CUSTOMER GROUPS with NOT LOGGED IN.
Nevertheless, the problem is still present when colliding ALL CUSTOMER GROUPS group with any other group.

Preconditions (*)

  1. Have a product created that has tier prices set as
    a. Website: All Websites, Group: All Groups, Quantity: 3, Price: Fixed, Value: 3
    b. Website: All Websites, Group: Not Logged In, Quantity: 3, Price: Fixed, Value: 3.5

Steps to reproduce (*)

  1. Execute the query and watch for response

Expected result (*)

  1. There is only one "final_price" with "quantity" = 3 in the response
  2. The lower price value for the given quantity is displayed only

Actual result (*)

  1. Quantity 3 is listed twice for the both customer groups

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2020

Hi @pmarjan. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jul 16, 2020
@pmarjan pmarjan changed the title Tier price for different customer group but same quantity are not filtered out Tier prices filtering in GraphLQl - prices for different customer group but same quantity are not filtered out Jul 16, 2020
@pmarjan pmarjan changed the title Tier prices filtering in GraphLQl - prices for different customer group but same quantity are not filtered out Tier prices filtering in GraphQl - prices for different customer group but same quantity are not filtered out Jul 16, 2020
@Usik2203
Copy link
Contributor

@magento I am working on this

@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for dev labels Sep 24, 2020
@ghost ghost added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Progress: done Project: GraphQL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants