Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] ChangeQuoteControl minor refactor #29673

Closed
4 tasks
m2-assistant bot opened this issue Aug 19, 2020 · 1 comment · Fixed by #29669
Closed
4 tasks

[Issue] ChangeQuoteControl minor refactor #29673

m2-assistant bot opened this issue Aug 19, 2020 · 1 comment · Fixed by #29669
Assignees
@lbajsarowicz
Labels
Component: Quote Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2020

This issue is automatically created based on existing pull request: #29669: ChangeQuoteControl minor refactor

Description (*)

Just a minor refactor to improve readability and Coding Standard
Unit Tests were ✔️ . I just removed redundant annotations (method names are perfectly descriptive) and replaced deprecated ObjectManager with new syntax.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Quote Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Aug 19, 2020
@lbajsarowicz lbajsarowicz mentioned this issue Aug 19, 2020
Merged
5 tasks
@ghost ghost assigned lbajsarowicz Aug 19, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 19, 2020
@ghost ghost added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Aug 19, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #29669 by @lbajsarowicz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.2 release.

@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbajsarowicz lbajsarowicz

Labels
Component: Quote Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ChangeQuoteControl minor refactor lbajsarowicz/magento2-contributions
2 participants
@lbajsarowicz @magento-engcom-team