Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Product Layout setting is not used anywhere relevant #30651

Closed
1 of 5 tasks
ericmorand opened this issue Oct 26, 2020 · 5 comments
Closed
1 of 5 tasks

Default Product Layout setting is not used anywhere relevant #30651

ericmorand opened this issue Oct 26, 2020 · 5 comments
Assignees
Labels
not-confirmed Use for Issue that was closed during confirmation Reported on 2.3.5 Indicates original Magento version for the Issue report.

Comments

@ericmorand
Copy link

ericmorand commented Oct 26, 2020

Preconditions (*)

Magento 2.3.5

Steps to reproduce (*)

  • In the back-office, change the configuration for General -> Web -> Default Layouts -> Default Product Layout to the layout of your choice.
  • In one of the catalog product, set the Layout attribute to No layout updates
  • Open the product detail page of this product

Expected result (*)

The page should be displayed using the layout set under General -> Web -> Default Layouts -> Default Product Layout.

Actual result (*)

It is not.

Workaround

It should be possible to create a plugin to the product view controller to fix that issue.


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Oct 26, 2020

Hi @ericmorand. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost
Copy link

ghost commented Oct 26, 2020

Actually, the framework is violating the principles of Separation of Concerns once again here, preventing the usage of a plugin to solve the issue:

#30653

@engcom-Delta engcom-Delta self-assigned this Oct 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 26, 2020

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

Hi @ericmorand , thank you for your report. Value fromGeneral -> Web -> Default Layouts -> Default Product Layout is applied for new products:
image

To change Design configuration for existing products you could use Update Attributes mass action:
image

If you'd like to update the issue, please reopen it.

@engcom-Delta engcom-Delta added the not-confirmed Use for Issue that was closed during confirmation label Oct 26, 2020
@ericmorand
Copy link
Author

@engcom-Delta , fair enough. Do you know what layout is used if none is selected at the product level or at any of its belonging categories level?

@sdzhepa sdzhepa added the Reported on 2.3.5 Indicates original Magento version for the Issue report. label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-confirmed Use for Issue that was closed during confirmation Reported on 2.3.5 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

3 participants