Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQl] Aggregations ignore attribute Position field. #30775

Closed
1 of 5 tasks
Hexmage opened this issue Nov 4, 2020 · 11 comments
Closed
1 of 5 tasks

[GraphQl] Aggregations ignore attribute Position field. #30775

Hexmage opened this issue Nov 4, 2020 · 11 comments
Assignees
Labels
Component: GraphQL GraphQL not-confirmed Use for Issue that was closed during confirmation

Comments

@Hexmage
Copy link

Hexmage commented Nov 4, 2020

Preconditions (*)

  1. 2.3.5p2

Steps to reproduce (*)

  1. Create a category and add a couple products with attributes with different values.
  2. Set the position for a couple attributes to different values. (eg. Color = position 10, Size = position 30)
  3. Do a GraphQl call requesting the aggregations to the products endpoint with the category as the filter.
query aggregations {
    products(filter:{category_id:{eq:"2"}}) {
        aggregations {
            count
            attribute_code
            options {
                value
                label
            }
            label
        }
    }
}
  1. Switch the positions of the attributes.
  2. Do a GraphQl call requesting the aggregations to the products endpoint with the category as the filter.

Expected result (*)

  1. The aggregations results are ordered differently between the 2 GraphQl calls based on how position is changed.

Actual result (*)

1.The aggregation results are identical.

Notes

As the aggregations are created based on the configuration of the attributes, the data should be returned sorted as set in the configuration. You can't expect the frontend to do this, because the returned data is not consistent between different categories and changes.


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Nov 4, 2020

Hi @Hexmage. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@Hexmage
Copy link
Author

Hexmage commented Nov 4, 2020

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @Hexmage. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@Hexmage
Copy link
Author

Hexmage commented Nov 4, 2020

Still an issue in 2.4-develop

@chiara-delrio
Copy link

I am having the same issue with GraphQL and Magento 2.4

@engcom-Bravo engcom-Bravo self-assigned this Dec 30, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 30, 2020

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

Hello @Hexmage

Thank you for your report.

We have tried to reproduce the reported issue on the latest 2.4-develop. In our case, the order of the attributes in the query is changed after changing the attributes position value.

Please, see our steps:

  1. Create a category and add a couple of products with attributes with different values.
    product

  2. Set the position for a couple attributes to different values. (eg. Color = position 10, Size = position 30)
    Color before
    Size before

  3. Do a GraphQl call requesting the aggregations to the product's endpoint with the category as the filter.
    before

  4. Switch the positions of the attributes by changing the Position value
    Color
    size

  5. Perform a GraphQLquery requesting the aggregations to the product's endpoint with the category as the filter.

query aggregations {
    products(filter:{category_id:{eq:"2"}}) {
        aggregations {
            count
            attribute_code
            options {
                value
                label
            }
            label
        }
    }
}

Actual result

  1. The aggregation's results are ordered differently between the 2 GraphQl calls based on how the position is changed.
    after

Can you please correct our steps in order we could reproduce the issue?

Thank you in Advance

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Dec 30, 2020
@Hexmage
Copy link
Author

Hexmage commented Dec 30, 2020

@engcom-Bravo looks like it got fixed on the 27th of November

c6aaabc

@engcom-Bravo
Copy link
Contributor

@Hexmage thank you for the quick response.
So we can Close this issue then.
Please feel free to comment or create a new ticket according to the Issue reporting guidelines

@engcom-Bravo engcom-Bravo added not-confirmed Use for Issue that was closed during confirmation and removed Issue: needs update Additional information is require, waiting for response labels Dec 30, 2020
@ghost
Copy link

ghost commented Jul 20, 2022

I was facing the same issue here. And i think that price filter in graphql does not work with position. I have set price filter position to 500, but still it always shows on top.

Any help will be appreciated

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GraphQL GraphQL not-confirmed Use for Issue that was closed during confirmation
Projects
None yet
Development

No branches or pull requests

4 participants