Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swatches missing when all products are out of stock #31268

Open
1 of 5 tasks
robbie-thompson opened this issue Dec 11, 2020 · 22 comments
Open
1 of 5 tasks

Swatches missing when all products are out of stock #31268

robbie-thompson opened this issue Dec 11, 2020 · 22 comments
Assignees
Labels
Area: Catalog Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reported on 2.4.1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@robbie-thompson
Copy link

Preconditions (*)

  1. Magento 2.4.1

Steps to reproduce (*)

  1. Install sample data
  2. Set Admin > Stores > Configuration > Catalog > Inventory > Stock Options > Display Out of Stock Products = Yes
  3. Create configurable product with multiple sizes
  4. Change all simple/size products to have 0 quantity and out of stock status

Expected result (*)

  1. All sizes still show on the frontend, but disabled/crossed out. Similar to this, but instead all of them are crossed out:
    image

Actual result (*)

  1. No sizes show on the frontend, which then also removes product price since no options are available:
    image

This behaviour has been reported many times before, however it has been addressed in 2.3 by crossing swatches out instead of not rendering them at all like it used to. This is definitely a step in the right direction, however it is still half-complete as you would expect this logic to apply for all the swatches - not just some of the time.


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Dec 11, 2020

Hi @robbie-thompson. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Dec 14, 2020

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ajijshekh123
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ajijshekh123. Thank you for your request. I'm working on Magento instance for you.

@ajijshekh123
Copy link

Hi @robbie-thompson,
As per your scenario, I have reproduced this issue on the latest Magento 2.4 instance. Whenever all the simple products, Set the status "Out of Stock" with Qty "0". The system is not displayed any of the size attributes with strike symbol but The system is displayed blank configurable products.
Screenshot:
image

image

Thanks.

@ajijshekh123 ajijshekh123 added Area: Frontend Component: Catalog Component: ConfigurableProduct Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Dec 14, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @ajijshekh123
Thank you for verifying the issue. Based on the provided information internal tickets MC-39873 were created

Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@gabrieldagama gabrieldagama added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 15, 2020
@ajithkumar-maragathavel
Copy link
Contributor

@magento I am working on this

@nordcomputer
Copy link

@ajithkumar-maragathavel Maybe it helps: i made an module, that shows the price and the swatches, when all child-products are out of stock:
https://github.com/nordcomputer/magento2-showoutofstockprice

You can switch, if you want to show the swatches in the backend. But it doesnt work with the classic select-field.

@engcom-Bravo engcom-Bravo removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: ConfigurableProduct Progress: dev in progress Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Area: Product labels May 31, 2024
@engcom-Bravo
Copy link
Contributor

Hi @robbie-thompson,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Install sample data
  • Set Admin > Stores > Configuration > Catalog > Inventory > Stock Options > Display Out of Stock Products = Yes
  • Create configurable product with multiple sizes
  • Change all simple/size products to have 0 quantity and out of stock status
Screenshot 2024-05-31 at 11 15 31

No sizes show on the frontend, which then also removes product price since no options are available

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Progress: ready for dev Reported on 2.4.1 Indicates original Magento version for the Issue report. labels May 31, 2024
@engcom-Bravo engcom-Bravo added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 31, 2024
@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 31, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12053 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented May 31, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-12053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Catalog Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reported on 2.4.1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Status: Dev In Progress
Development

No branches or pull requests