Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark moved interfaces as API #32038

Open
sivaschenko opened this issue Feb 9, 2021 · 3 comments
Open

Mark moved interfaces as API #32038

sivaschenko opened this issue Feb 9, 2021 · 3 comments
Labels
has dependency Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Project: API Changes
Milestone

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Feb 9, 2021

The following interfaces should be moved and marked as API

Depends on #32040 (moving and deprecation of interfaces in 2.4)

  1. app/code/Magento/AsynchronousOperations/Model/OperationRepositoryInterface.php: Move to \Magento\AsynchronousOperations\Model\ResourceModel\Operation\OperationRepository and then mark as @api in 2.5. Deprecate in 2.4
  2. lib/internal/Magento/Framework/View/Asset/PreProcessor/Helper/SortInterface.php: Move out from /Helper/ namespace and then mark as API in 2.5. Deprecate in 2.4
  3. app/code/Magento/Quote/Model/GuestCart/GuestShippingMethodManagementInterface.php: Interface with the same name exists in /Api/ scope, which is confusing. Need to refactor somehow to eliminate confusion and then mark as @api in 2.5. Deprecate in 2.4
  4. app/code/Magento/Quote/Model/ShippingMethodManagementInterface.php: Interface with the same name exists in /Api/ scope, which is confusing. Need to refactor somehow to eliminate confusion and then mark as @api in 2.5. Deprecate in 2.4
  5. app/code/Magento/MediaGalleryUi/Model/InsertImageDataInterface.php: This interface should be extracted to a separate module together with GetInsertImageData and GetInsertImageContent services and marked as APIa
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 9, 2021
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sivaschenko sivaschenko changed the title Move interfaces and mark as API Mark moved interfaces as API Feb 9, 2021
@AndreyChorniy
Copy link
Contributor

@magento I am working on this

@AndreyChorniy
Copy link
Contributor

Hello @sivaschenko,
I would like to clarify point 5 from your description

app/code/Magento/MediaGalleryUi/Model/InsertImageDataInterface.php: This interface should be extracted to a separate module together with GetInsertImageData and GetInsertImageContent services and marked as API

Questions:

  1. GetInsertImageData and GetInsertImageContent this is not interfaces and they should not be marked as API as well. Is this is the correct suggestion?
  2. Do we need to create a separate extension for only one interface app/code/Magento/MediaGalleryUi/Model/InsertImageDataInterface.php:? Is this is a good solution to create a folder API for extension MediaGalleryUi and move this interface to this folder.

Please advise.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has dependency Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Project: API Changes
Projects
Status: Ready for Development
Development

No branches or pull requests

2 participants