Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Sales Blocks as API part 1 #32046

Closed
sivaschenko opened this issue Feb 9, 2021 · 3 comments
Closed

Mark Sales Blocks as API part 1 #32046

sivaschenko opened this issue Feb 9, 2021 · 3 comments
Assignees
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes
Milestone

Comments

@sivaschenko
Copy link
Member

The following Blocks should be marked as API in 2.5-develop branch

  1. Magento\Sales\Block\Widget\Guest\Form
  2. Magento\Sales\Block\Adminhtml\Items\Renderer\DefaultRenderer
  3. Magento\Sales\Block\Adminhtml\Items\Column\Name
  4. Magento\Sales\Block\Adminhtml\Items\Column\DefaultColumn
  5. Magento\Sales\Block\Adminhtml\Order\AbstractOrder
  6. Magento\Sales\Block\Adminhtml\Order\Payment
  7. Magento\Sales\Block\Adminhtml\Order\Comments\View
  8. Magento\Sales\Block\Adminhtml\Order\Totals\Item
  9. Magento\Sales\Block\Adminhtml\Order\Totals\Tax
  10. Magento\Sales\Block\Adminhtml\Order\Create\Data
  11. Magento\Sales\Block\Adminhtml\Order\Create\Customer
  12. Magento\Sales\Block\Adminhtml\Order\Create\Coupons
  13. Magento\Sales\Block\Adminhtml\Order\Create\Totals
  14. Magento\Sales\Block\Adminhtml\Order\Create\Store
  15. Magento\Sales\Block\Adminhtml\Order\Create\Sidebar
  16. Magento\Sales\Block\Adminhtml\Order\Create\Form
  17. Magento\Sales\Block\Adminhtml\Order\Create\Newsletter
  18. Magento\Sales\Block\Adminhtml\Order\Create\Search
  19. Magento\Sales\Block\Adminhtml\Order\Create\Comment
  20. Magento\Sales\Block\Adminhtml\Order\Create\Giftmessage
  21. Magento\Sales\Block\Adminhtml\Order\Create\Items
  22. Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\Wishlist
  23. Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\Pviewed
  24. Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\Pcompared
  25. Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\Cart
  26. Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\Reorder
  27. Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\Compared
  28. Magento\Sales\Block\Adminhtml\Order\Create\Sidebar\Viewed
  29. Magento\Sales\Block\Adminhtml\Order\Create\Billing\Address
  30. Magento\Sales\Block\Adminhtml\Order\Create\Billing\Method
  31. Magento\Sales\Block\Adminhtml\Order\Create\Billing\Method\Form
  32. Magento\Sales\Block\Adminhtml\Order\Create\Coupons\Form
  33. Magento\Sales\Block\Adminhtml\Order\Create\Items\Grid
  34. Magento\Sales\Block\Adminhtml\Order\Create\Form\Account
  35. Magento\Sales\Block\Adminhtml\Order\Create\Shipping\Address
  36. Magento\Sales\Block\Adminhtml\Order\Create\Shipping\Method
  37. Magento\Sales\Block\Adminhtml\Order\Create\Shipping\Method\Form
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 9, 2021
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @edenduong. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@edenduong
Copy link
Contributor

Hi @sivaschenko,

I check Sales Blocks class but I see it has been marked @api . So we should add additional information or do nothing ?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes
Projects
None yet
Development

No branches or pull requests

2 participants