Mark Sales Blocks as API part 2

[sivaschenko]

The following Blocks should be marked as API in 2.5-develop branch

1. Magento\Sales\Block\Adminhtml\Order\Invoice\Totals
2. Magento\Sales\Block\Adminhtml\Order\Invoice\Create\Form
3. Magento\Sales\Block\Adminhtml\Order\Invoice\Create\Items
4. Magento\Sales\Block\Adminhtml\Order\Invoice\View\Form
5. Magento\Sales\Block\Adminhtml\Order\Invoice\View\Comments
6. Magento\Sales\Block\Adminhtml\Order\Invoice\View\Items
7. Magento\Sales\Block\Adminhtml\Order\Creditmemo\Totals
8. Magento\Sales\Block\Adminhtml\Order\Creditmemo\Create\Form
9. Magento\Sales\Block\Adminhtml\Order\Creditmemo\Create\Adjustments
10. Magento\Sales\Block\Adminhtml\Order\Creditmemo\Create\Items
11. Magento\Sales\Block\Adminhtml\Order\Creditmemo\View\Form
12. Magento\Sales\Block\Adminhtml\Order\Creditmemo\View\Comments
13. Magento\Sales\Block\Adminhtml\Order\Creditmemo\View\Items
14. Magento\Sales\Block\Adminhtml\Order\View\Tabs
15. Magento\Sales\Block\Adminhtml\Order\View\History
16. Magento\Sales\Block\Adminhtml\Order\View\Giftmessage
17. Magento\Sales\Block\Adminhtml\Order\View\Info
18. Magento\Sales\Block\Adminhtml\Order\View\Items
19. Magento\Sales\Block\Adminhtml\Order\View\Items\Renderer\DefaultRenderer
20. Magento\Sales\Block\Adminhtml\Order\View\Tab\Shipments
21. Magento\Sales\Block\Adminhtml\Order\View\Tab\Invoices
22. Magento\Sales\Block\Adminhtml\Order\View\Tab\Creditmemos
23. Magento\Sales\Block\Adminhtml\Order\View\Tab\Info
24. Magento\Sales\Block\Adminhtml\Order\View\Tab\Transactions
25. Magento\Sales\Block\Reorder\Sidebar
26. Magento\Sales\Block\Order\Invoice
27. Magento\Sales\Block\Order\View
28. Magento\Sales\Block\Order\Recent
29. Magento\Sales\Block\Order\History
30. Magento\Sales\Block\Order\Totals
31. Magento\Sales\Block\Order\Creditmemo
32. Magento\Sales\Block\Order\PrintShipment
33. Magento\Sales\Block\Order\Comments
34. Magento\Sales\Block\Order\Info
35. Magento\Sales\Block\Order\Items
36. Magento\Sales\Block\Order\Email\Items
37. Magento\Sales\Block\Order\Email\Items\DefaultItems
38. Magento\Sales\Block\Order\Email\Items\Order\DefaultOrder
39. Magento\Sales\Block\Order\Email\Invoice\Items
40. Magento\Sales\Block\Order\Email\Creditmemo\Items
41. Magento\Sales\Block\Order\Email\Shipment\Items
42. Magento\Sales\Block\Order\Invoice\Totals
43. Magento\Sales\Block\Order\Invoice\Items
44. Magento\Sales\Block\Order\History\Container
45. Magento\Sales\Block\Order\Creditmemo\Totals
46. Magento\Sales\Block\Order\Creditmemo\Items
47. Magento\Sales\Block\Order\Item\Renderer\DefaultRenderer
48. Magento\Sales\Block\Order\Info\Buttons
49. Magento\Sales\Block\Order\Info\Buttons\Rss
50. Magento\Sales\Block\Order\PrintOrder\Invoice
51. Magento\Sales\Block\Order\PrintOrder\Shipment
52. Magento\Sales\Block\Order\PrintOrder\Creditmemo

[m2-assistant]

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @edenduong. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[edenduong]

Hi @sivaschenko,

I check Sales Blocks class but I see it has been marked @api . So we should add additional information or do nothing ?

Thanks.

[sivaschenko]

Thanks for checking @edenduong ! I will review the blocks lists for all tasks