Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Customer, User, Directory, Store and Cms Blocks as API #32048

Closed
sivaschenko opened this issue Feb 9, 2021 · 5 comments
Closed

Mark Customer, User, Directory, Store and Cms Blocks as API #32048

sivaschenko opened this issue Feb 9, 2021 · 5 comments
Assignees
Labels
Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Milestone

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Feb 9, 2021

The following Blocks should be marked as API in 2.5-develop branch

  1. Magento\Customer\Block\SectionConfig
  2. Magento\Customer\Block\CustomerData
  3. Magento\Customer\Block\CustomerScopeData
  4. Magento\Customer\Block\Newsletter
  5. Magento\Customer\Block\Address\Grid
  6. Magento\Customer\Block\Address\Book
  7. Magento\Customer\Block\Address\Edit
  8. Magento\Customer\Block\Form\Edit
  9. Magento\Customer\Block\Form\Register
  10. Magento\Customer\Block\Form\Login
  11. Magento\Customer\Block\Form\Login\Info
  12. Magento\Customer\Block\Account\SortLinkInterface
  13. Magento\Customer\Block\Account\Resetpassword
  14. Magento\Customer\Block\Account\Delimiter
  15. Magento\Customer\Block\Account\Customer
  16. Magento\Customer\Block\Account\Dashboard
  17. Magento\Customer\Block\Account\Link
  18. Magento\Customer\Block\Account\AuthorizationLink
  19. Magento\Customer\Block\Account\Forgotpassword
  20. Magento\Customer\Block\Account\AuthenticationPopup
  21. Magento\Customer\Block\Account\Dashboard\Address
  22. Magento\Customer\Block\Account\Dashboard\Info
  23. Magento\User\Block\Buttons
  24. Magento\Directory\Block\Currency
  25. Magento\Store\Block\Switcher
  26. Magento\Cms\Block\Page
  27. Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Content
  28. Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Tree
  29. Magento\Cms\Block\Adminhtml\Wysiwyg\Images\Content\Files
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 9, 2021
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@mrtuvn
Copy link
Contributor

mrtuvn commented Feb 10, 2021

@magento I am working on this

@m2-community-project m2-community-project bot assigned mrtuvn and unassigned mrtuvn Feb 14, 2021
@gabrieldagama gabrieldagama removed this from the 2.5 milestone Apr 1, 2021
@engcom-Oscar engcom-Oscar added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 6, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-41769 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@gabrieldagama
Copy link
Contributor

All the classes are already marked as API.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label May 28, 2021
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, @mrtuvn.

Thank you for your report and collaboration!

The related internal Jira ticket MC-41769 was closed as Fixed.

The fix will be available with the upcoming 2.4.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants