Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Theme, Eav, Ui, Rss, Wishlist and Downloadable Blocks as API #32049

Closed
sivaschenko opened this issue Feb 9, 2021 · 5 comments
Closed

Mark Theme, Eav, Ui, Rss, Wishlist and Downloadable Blocks as API #32049

sivaschenko opened this issue Feb 9, 2021 · 5 comments
Assignees
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes
Milestone

Comments

@sivaschenko
Copy link
Member

The following Blocks should be marked as API in 2.5-develop branch

  1. Magento\Theme\Block\Html\Header
  2. Magento\Theme\Block\Html\Notices
  3. Magento\Theme\Block\Html\Footer
  4. Magento\Theme\Block\Html\Pager
  5. Magento\Theme\Block\Html\Breadcrumbs
  6. Magento\Theme\Block\Html\Topmenu
  7. Magento\Theme\Block\Html\Title
  8. Magento\Theme\Block\Html\Header\Logo
  9. Magento\Theme\Block\Adminhtml\Design\Config\Edit\Scope
  10. Magento\Theme\Block\Adminhtml\Wysiwyg\Files\Content
  11. Magento\Theme\Block\Adminhtml\Wysiwyg\Files\Tree
  12. Magento\Theme\Block\Adminhtml\Wysiwyg\Files\Content\Files
  13. Magento\Theme\Block\Adminhtml\Wysiwyg\Files\Content\Uploader
  14. Magento\Eav\Block\Adminhtml\Attribute\Edit\Options\Labels
  15. Magento\Eav\Block\Adminhtml\Attribute\Edit\Options\Options
  16. Magento\Ui\Block\Logger
  17. Magento\Ui\Block\Wysiwyg\ActiveEditor
  18. Magento\Ui\Block\Component\StepsWizard
  19. Magento\Rss\Block\Feeds
  20. Magento\Wishlist\Block\AddToWishlist
  21. Magento\Wishlist\Block\Link
  22. Magento\Wishlist\Block\Rss\Link
  23. Magento\Wishlist\Block\Item\Configure
  24. Magento\Wishlist\Block\Cart\Item\Renderer\Actions\MoveToWishlist
  25. Magento\Wishlist\Block\Customer\Sharing
  26. Magento\Wishlist\Block\Customer\Wishlist\Button
  27. Magento\Wishlist\Block\Customer\Wishlist\Items
  28. Magento\Downloadable\Block\Sales\Order\Email\Items\Downloadable
  29. Magento\Downloadable\Block\Sales\Order\Email\Items\Order\Downloadable
  30. Magento\Downloadable\Block\Sales\Order\Item\Renderer\Downloadable
  31. Magento\Downloadable\Block\Adminhtml\Sales\Items\Column\Downloadable\Name
  32. Magento\Downloadable\Block\Checkout\Success
  33. Magento\Downloadable\Block\Checkout\Cart\Item\Renderer
  34. Magento\Downloadable\Block\Customer\Products\ListProducts
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 9, 2021
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@vlmed
Copy link
Contributor

vlmed commented Feb 10, 2021

@magento i am working on this

@vlmed
Copy link
Contributor

vlmed commented Feb 10, 2021

@magento i am working on this

@vlmed
Copy link
Contributor

vlmed commented Feb 10, 2021

Hello @sivaschenko,

I checked all Blocks class from this issue and all of them have already marked as @api . So should I add additional information or do nothing?
Thanks.

@sivaschenko
Copy link
Member Author

Thanks for checking @vlmed, nothing should be done, I will recheck the blocks lists for all tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes
Projects
None yet
Development

No branches or pull requests

2 participants