Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Newsletter, Review, PageCache, Tax, Payment, Contact, Shipping and ImportExport Blocks as API #32050

Closed
sivaschenko opened this issue Feb 9, 2021 · 5 comments
Assignees
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes
Milestone

Comments

@sivaschenko
Copy link
Member

The following Blocks should be marked as API in 2.5-develop branch

  1. Magento\Newsletter\Block\Subscribe
  2. Magento\Newsletter\Block\Adminhtml\Subscriber
  3. Magento\Newsletter\Block\Adminhtml\Problem
  4. Magento\Newsletter\Block\Adminhtml\Template\Edit
  5. Magento\Newsletter\Block\Adminhtml\Queue\Edit
  6. Magento\Review\Block\Adminhtml\Rss\Grid\Link
  7. Magento\Review\Block\Customer\Recent
  8. Magento\Review\Block\Customer\ListCustomer
  9. Magento\Review\Block\Product\Review
  10. Magento\Review\Block\Product\View\Other
  11. Magento\PageCache\Block\Javascript
  12. Magento\PageCache\Block\System\Config\Form\Field\Export
  13. Magento\Tax\Block\Sales\Order\Tax
  14. Magento\Tax\Block\Adminhtml\Items\Price\Renderer
  15. Magento\Tax\Block\Adminhtml\Rate\Toolbar\Add
  16. Magento\Tax\Block\Item\Price\Renderer
  17. Magento\Payment\Block\Transparent\Redirect
  18. Magento\Payment\Block\Transparent\Form
  19. Magento\Contact\Block\ContactForm
  20. Magento\Shipping\Block\Items
  21. Magento\Shipping\Block\Tracking\Link
  22. Magento\Shipping\Block\Tracking\Popup
  23. Magento\Shipping\Block\Adminhtml\Create\Form
  24. Magento\Shipping\Block\Adminhtml\Create\Items
  25. Magento\Shipping\Block\Adminhtml\Order\Tracking
  26. Magento\Shipping\Block\Adminhtml\Order\Packaging
  27. Magento\Shipping\Block\Adminhtml\Order\Tracking\Invoice
  28. Magento\Shipping\Block\Adminhtml\Order\Tracking\View
  29. Magento\Shipping\Block\Adminhtml\View\Form
  30. Magento\Shipping\Block\Adminhtml\View\Comments
  31. Magento\Shipping\Block\Adminhtml\View\Items
  32. Magento\Shipping\Block\Order\Shipment
  33. Magento\ImportExport\Block\Adminhtml\Import\Edit\Before
  34. Magento\ImportExport\Block\Adminhtml\Import\Frame\Result
  35. Magento\ImportExport\Block\Adminhtml\Form\After
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 9, 2021
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@vlmed
Copy link
Contributor

vlmed commented Feb 10, 2021

@magento i am working on this

@ProkopovVitaliy
Copy link
Contributor

@magento i am working on this

@ProkopovVitaliy
Copy link
Contributor

@sivaschenko all of the mentioned classes already marked as api in this commit a6e43abdcecce2b063b314aae73cede677c029bc.

@sivaschenko
Copy link
Member Author

Thanks for checking @ProkopovVitaliy ! I will review the list of blocks for all the tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes
Projects
None yet
Development

No branches or pull requests

3 participants