Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark classes and interfaces as API part 3 #32058

Closed
sivaschenko opened this issue Feb 9, 2021 · 7 comments · Fixed by #32735
Closed

Mark classes and interfaces as API part 3 #32058

sivaschenko opened this issue Feb 9, 2021 · 7 comments · Fixed by #32735
Assignees
@Usik2203
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Feb 9, 2021 •
edited by gabrieldagama
Loading

The following classes and interfaces should be marked as API in 2.4-develop branch

  1. Magento\Framework\Data\Form\Element\Image
  2. Magento\Sales\Model\Order\Pdf\Total\DefaultTotal
  3. Magento\Catalog\Block\Adminhtml\Product\Edit\Button\Generic
  4. Magento\Sales\Controller\Adminhtml\Order
  5. Magento\Customer\Setup\CustomerSetup
  6. Magento\Checkout\Controller\Cart
  7. Magento\Quote\Model\Quote\Item\CartItemOptionsProcessor
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 9, 2021
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sivaschenko sivaschenko mentioned this issue Feb 9, 2021
Open
@ProkopovVitaliy
Copy link
Contributor

@magento i am working on this

@ProkopovVitaliy ProkopovVitaliy removed their assignment Feb 10, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Feb 13, 2021 •
edited
Loading

Magento\Framework\View\DesignInterface seem duplicate in some other issue related
Note for @sivaschenko

@sivaschenko
Copy link
Member Author

Thanks, @mrtuvn ! Can you please share the links to the issues it's mentioned on?

@mrtuvn
Copy link
Contributor

mrtuvn commented Feb 15, 2021

#32037 @sivaschenko
DesignInterface mark also note here

@Usik2203
Copy link
Contributor

@magento I am working on this

@sivaschenko
Copy link
Member Author

Thanks @mrtuvn , @Usik2203 Magento\Framework\View\DesignInterface removed from this task in favour of #32037

@Usik2203 Usik2203 mentioned this issue Feb 16, 2021
Closed
4 tasks
@gabrieldagama gabrieldagama removed this from the 2.5 milestone Apr 1, 2021
@Usik2203 Usik2203 mentioned this issue Apr 13, 2021
Merged
@m2-community-project m2-community-project bot assigned Usik2203 and unassigned Usik2203 Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Usik2203 Usik2203

Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: API Changes
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[32058][To 2.4-develop] Marked classes and interfaces as API part 3 Usik2203/magento2
5 participants
@mrtuvn @sivaschenko @gabrieldagama @Usik2203 @ProkopovVitaliy