Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory] Remove StockExtension class and interface #32089

Open
sivaschenko opened this issue Feb 10, 2021 · 3 comments
Open

[Inventory] Remove StockExtension class and interface #32089

sivaschenko opened this issue Feb 10, 2021 · 3 comments
Assignees
@ProkopovVitaliy
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: dev in progress Project: API Changes
Milestone
2.5

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Feb 10, 2021 •
edited
Loading

Description

Even though extension attributes PHP classes/interfaces were not supposed to be created manually, we have several such occurrences.
It is preferable to remove these classes/interfaces because they block extensibility of the base interfaces.

Details

Remove Magento\InventoryApi\Api\Data\StockExtension and Magento\InventoryApi\Api\Data\StockExtensionInterface in future-develop branch
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 10, 2021
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 10, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 10, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sivaschenko sivaschenko changed the title [Inventory] Remove Magento\InventoryApi\Api\Data\StockExtension [Inventory] Remove StockExtension class and interface Feb 10, 2021
@ProkopovVitaliy
Copy link
Contributor

@magento i am working on this

@sivaschenko sivaschenko mentioned this issue Feb 10, 2021
Open
@ProkopovVitaliy ProkopovVitaliy mentioned this issue Feb 10, 2021
Closed
4 tasks
@sdouma
Copy link

sdouma commented Sep 30, 2022

@magento-engcom-team can we get movement on this? This breaks any extending the stock interface and has been a pain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ProkopovVitaliy ProkopovVitaliy

Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: dev in progress Project: API Changes
Projects
None yet
Milestone
2.5
Development

No branches or pull requests
3 participants
@sivaschenko @sdouma @ProkopovVitaliy