-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Layered Navigation not show attributes with "Filterable (with Results)" #3209
Comments
@redicer Thanks for reporting, definitely sounds like a bug. We have created ticket MAGETWO-48639 to investigate. |
Is it fixed? |
Is your test category a sub-category of another non-root category? Does your test category have any of its own sub-categories? |
Same here, attribute shows when attribute is set |
seems better/fixed in 2.1.0 -- I haven't tested thoroughly but Layered Navigation seems much better in 2.1.0 |
No it is not - as I pointed out higher. Attribute assigned |
I'm having the same issue using the color attribute on 2.1.0. |
@alphatwenty Same on 2.0.10 |
Same here on Magento 2.1.0 CE. Attributes set to |
Anything new about this? |
I'm not sure what the answer is but I managed to get my options to show by changing from "<" to "<=" in vendor/magento/module-catalog/Model/Layer/Filter/AbstractFilter.php Version: 2.1.2
I've been fussing with it for hours and not sure this is the answer.. |
@sclubricants Thank you so much, this seems to fix the problem and my missing attributes are back! |
@kandy Any update on this bug? |
We have found this issue on multiple builds, any news @kandy? |
Looks like we can not reproduce this issue internally. Maybe I need to clarify something about filters in LN.
For example, if we have 5 configurable product and all have all variations of color attribute the filter will not be shown. Or if a category has only one product, filters will not shown too. |
@kandy This works for me, thanks! |
Thanks sclubricants! This works for me. |
@sclubricants This works for me, BUT is a core fix of course. We can't however, fix this in a problem because this is a protected function and you can't overwrite that with a plugin. Any idea on how we can do this? |
@TommyKolkman take another look at @kandy's last reply and try to digest it a little more. In my case, point 2 hit the nail on the head for us: "The option is not shown if it will not decrease numbers of product on page" |
Agree with @TommyKolkman , the user experience in this situation is not ideal, we have the same thing where customers think we do not have any of those sizes etc as they don't show up. @TommyKolkman how did you resolve or work around this? |
Our issue was that the type of filterable attributes was set to "text". We have changed the type to "varchar" and got the filter (with results) working. |
This issue is is still in in 2.1.6 and above solution does not work |
It does not seem to be a bug. If the price, or any other Attribute, is not showing up is because all of your products are going to be included in one option only, eg: Red (0), Green(0), Blue (4). To resolve Price issues try: As far as my experience with this issue goes, for other Attributes, if this bother you, this bug report should be turned into a feature request. For me it works as expected. Cheers |
@maghamed I find your approach to be very technical. I rather view this problem from the user's perspective: If a user is on a list page and wants to buy shoes, the user will want to apply a filter with their size, so that only shoes that are available in their size will show. This has become impossible. Either the shop owner can configure the size filter to be able to render options with 0 results, resulting in displaying all sizes in the catalog, even for non-shoes, or the shop owner sets the attribute to Filterable (with results) and he loses the options that are present on all products in the category as well as options that have 0 results. The result: customers will think that their size is not available, while it is available on all products on the page. They will not buy products because they'll think these products are out of stock. This is a conversion killer. So there is a bug: Filterable (with results) makes no difference between options that have no results and options that have the full product collection as a result. This started here: 3fd3c55 It is a functional change that is different from Magento 2.0.x and Magento 1.x. If there is a possibility for an endless loop, please fix that instead of making functional changes to work around it. |
@ajpevers @Ctucker9233 @TommyKolkman current behavior not to show Layered Navigation filter if applying this filter doesn't lead to reduce result set is not elegant. But that's not exactly how we see our Desired Vision for Layered Navigation.
That work has not been finished on Hackathon, and we have a corresponding internal ticket for it - MAGETWO-35969.
Second: to get Search Results with all filters applied This behavior is similar to one implemented on Amazon Based on the above if we will implement #9096 story, we will automatically achieve a behaviour requested in the scope of current issue (not to show Layered Navigation filter if applying this filter doesn't lead to reduce result set is not elegant.), because we are not going to shrink LN anymore. That's why I believe we will invest resources to #9096 story than into current issue, because it doesn't make us closer to the desired state. But if community will deliver in Pull Request, we can apply it while we didn't implement #9096 Added Search Product Owner @choukalos for his insight |
@sclubricants solution works for me as well in magento 2.1.4 . My attributes are back now |
@redicer, thank you for your report. |
Thank you for your submission. We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues. Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here). We are closing this GitHub ticket and have moved your request to the new forum. |
Preconditions
Steps to reproduce
Expected result
Price filter is visible.
Actual result
Attribute 'Сolor' display begins. But the "Price" is still not visible.
In /var/log/system.log
[2016-01-29 23:21:49] main.INFO: Cache file with merged layout: LAYOUT_frontend_STORE1_28f8f27b8478aea82e0ee080b652907b7: Please correct the XML data and try again. [] []
[2016-01-29 23:21:49] main.INFO: Cache file with merged layout: LAYOUT_frontend_STORE1_2a7ccd8094436548b564a588f6303121c: Please correct the XML data and try again. [] []
[2016-01-29 23:21:49] main.CRITICAL: Broken reference: the 'store.settings.currency' tries to reorder itself towards 'store_language', but their parents are different: 'store.settings' and 'header.panel' respectively. [] []
[2016-01-29 23:21:49] main.INFO: Cache file with merged layout: LAYOUT_frontend_STORE1_26f1b068ec7ccf4878f9284dd1137afd1: Please correct the XML data and try again. [] []
[2016-01-29 23:21:54] main.INFO: Cache file with merged layout: LAYOUT_frontend_STORE1_2d41d8cd98f00b204e9800998ecf8427e: Please correct the XML data and try again. [] []
[2016-01-29 23:23:04] main.INFO: Cache file with merged layout: LAYOUT_adminhtml_STORE1_3942059a62c87af8724fe1ef3f757dc31: Please correct the XML data and try again. [] []
[2016-01-29 23:23:04] main.CRITICAL: Broken reference: the 'header' tries to reorder itself towards 'global.notices', but their parents are different: 'page.wrapper' and 'notices.wrapper' respectively. [] []
[2016-01-29 23:23:04] main.CRITICAL: Broken reference: the 'page.breadcrumbs' tries to reorder itself towards 'notifications', but their parents are different: 'page.wrapper' and 'notices.wrapper' respectively. [] []
[2016-01-29 23:23:04] main.CRITICAL: Broken reference: the 'global.search' tries to reorder itself towards 'notification.messages', but their parents are different: 'header.inner.right' and 'header' respectively. [] []
[2016-01-29 23:23:10] main.INFO: Cache file with merged layout: LAYOUT_adminhtml_STORE1_3d377266e3d6552ca5fe63f5fe36483b7: Please correct the XML data and try again. [] []
[2016-01-29 23:23:10] main.INFO: Cache file with merged layout: LAYOUT_adminhtml_STORE1_3793edbdc1c00dd1c3aa9e1b3dc856b39: Please correct the XML data and try again. [] []
[2016-01-29 23:23:11] main.CRITICAL: Broken reference: the 'header' tries to reorder itself towards 'global.notices', but their parents are different: 'page.wrapper' and 'notices.wrapper' respectively. [] []
[2016-01-29 23:23:11] main.CRITICAL: Broken reference: the 'page.breadcrumbs' tries to reorder itself towards 'notifications', but their parents are different: 'page.wrapper' and 'notices.wrapper' respectively. [] []
[2016-01-29 23:23:11] main.CRITICAL: Broken reference: the 'global.search' tries to reorder itself towards 'notification.messages', but their parents are different: 'header.inner.right' and 'header' respectively. [] []
Do you have any ideas about this?
The text was updated successfully, but these errors were encountered: