Missing dependency in Magento/JwtFrameworkAdapter

[fooman]

Preconditions (*)

1. 2.4-develop

Steps to reproduce (*)

1. check https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/JwtFrameworkAdapter/Model/JweManager.php#L11
2. notice use Jose\Component\Encryption\JWEBuilder;
3. check https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/JwtFrameworkAdapter/composer.json

Expected result (*)

1. web-token/jwt-framework to be declared as dependency in the module that uses it magento/module-jwt-framework-adapter

Actual result (*)

1. defined on the global level https://github.com/magento/magento2/blob/2.4-develop/composer.json#L87

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @fooman. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[ihor-sviziev]

Hi @fooman,
Could you create a PR for fixing this issue?

[magento-engcom-team]

@bgorski Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

• Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

[magento-engcom-team]

@m2-community-project[bot] Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

• Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

[bgorski]

ok, now I know that this wasn't marked as confirmed in the first place. I'll go ahead and create a PR for this tomorrow if still needed.

[magento-engcom-team]

✅ Confirmed by @ihor-sviziev
Thank you for verifying the issue. Based on the provided information internal tickets MC-41613 were created

Issue Available: @ihor-sviziev, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[ihor-sviziev]

@sivaschenko @sidolov @gabrieldagama from my perspective missing dependency should be treated as P2 priority as it might cause not obvious issues from developer perspective

[sivaschenko]

@sidolov @gabrieldagama @ihor-sviziev priority is set to P2 as this issue not only affect the dev experience but also can lead to potential errors during codebase analysis, design and automation.

[gabrieldagama]

Hi @fooman. Thank you for your report.
The issue has been fixed in #32612 by @bgorski in 2.4-develop branch
Related commit(s):

• 7306e85cfabd31582c4c366ef90820aa85825963

The fix will be available with the upcoming 2.4.3 release.