-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Braintree plugin breaks when JS minify is turned on #3916
Comments
The Braintree module on the current develop branch require only minified version of sdk https://github.com/magento/magento2/blob/develop/app/code/Magento/Braintree/view/frontend/requirejs-config.js#L9 and https://github.com/magento/magento2/blob/develop/app/code/Magento/Braintree/etc/config.xml#L34 |
Hi @middlegrey, If the issue still persist, please provide us with exact steps to reproduce and specify magento version that you are using. |
Hi Alena, To get around the problem, I changed the external resource string in requirejs-config.js to https://js.braintreegateway.com/v2/braintree.js?nomin And am currently using 2.0.2 |
Hi @middlegrey This issue is already solved in develop branchby using minified version of sdk only https://github.com/magento/magento2/blob/develop/app/code/Magento/Braintree/view/frontend/requirejs-config.js#L9 and https://github.com/magento/magento2/blob/develop/app/code/Magento/Braintree/etc/config.xml#L34 |
In the Braintree module's requirejs-config.js, the external resource https://js.braintreegateway.com/v2/braintree.js is specified.
When JS minify is turned on, the system tries to load https://js.braintreegateway.com/v2/braintree.min.js which doesn't exist, breaking the page.
The text was updated successfully, but these errors were encountered: