Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQl Schema Is Not Cached With Redis #39168

Closed
5 tasks
m08110071 opened this issue Sep 13, 2024 · 7 comments · May be fixed by #39172
Closed
5 tasks

GraphQl Schema Is Not Cached With Redis #39168

m08110071 opened this issue Sep 13, 2024 · 7 comments · May be fixed by #39172
Assignees
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@m08110071
Copy link

m08110071 commented Sep 13, 2024

Preconditions and environment

  • Magento 2.4.7-p2
  • Redis 7.2 and config requirepass
  • Config redis for cache and specific cache prefix id
  • Enable all cache types

Steps to reproduce

  • Call any GraphQl query and debug to file: vendor/magento/framework/Config/Data.php:108

Expected result

GraphQl schema is cached

Actual result

GraphQl schema is not cached

image

Additional information

  1. I tried to debug and see this issue happen since below code added:

File: vendor/magento/module-catalog-graph-ql/etc/di.xml

<virtualType name="Magento\Framework\GraphQl\Config\Data" type="Magento\Framework\Config\Data"> <arguments> <argument name="cacheTags" xsi:type="array"> <!-- Note: Because of DynamicAttributeReaders, this cache needs to be cleaned when attributes change--> <item name="EAV" xsi:type="string">EAV</item> </argument> </arguments> </virtualType>

  1. Some cases, cache is stored to file automatically

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Sep 13, 2024

Hi @m08110071. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo added Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. labels Sep 13, 2024
@m08110071
Copy link
Author

m08110071 commented Sep 16, 2024

@engcom-Bravo This is my PR to fix It:
#39172

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 17, 2024
@engcom-November engcom-November self-assigned this Sep 18, 2024
Copy link

m2-assistant bot commented Sep 18, 2024

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hello @m08110071,

Thank you for the report and collaboration!

Not able to reproduce this on 2.4-develop with redis cache configured.
When calling the graphql query second time, the cacheId is being cached.

Please take a look at the screenshot below:
image

And also the same key can be seen in redis as well:
image

Please let us know if we are missing anything.

Thank you.

@engcom-November engcom-November added Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation labels Sep 18, 2024
@m08110071
Copy link
Author

Hi @engcom-November

Please try to with Adobe Commerce 2.4.7-p2.

You can check my PR to resolve this issue to understand the issue. I debugged and see this issue happen because EAV is added as new Redis cache tag at vendor/colinmollenhour/credis/Client.php::_flattenArguments.

@engcom-November
Copy link
Contributor

Hello @m08110071,

Tried with 2.4.7-p2 community and commerce eddition with requirepass, but in both the cases this is not reproducible.
We are getting the same result:
image

Please let us know if there are any pre conditions required.

Thank you.

@engcom-November
Copy link
Contributor

Hello @m08110071,

This issue is being closed since it has not been updated in a long time.
Please feel free to reopen or raise a new ticket if the issue still exists.

Thank you.

@engcom-Bravo engcom-Bravo removed the Issue: needs update Additional information is require, waiting for response label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.7-p2 Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants