Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Ignore lib/internal/Magento/Framework/App/Test/Unit/_files/app/etc/en… #39304

Open
2 of 5 tasks
m2-assistant bot opened this issue Oct 28, 2024 · 2 comments · May be fixed by #37631
Open
2 of 5 tasks

[Issue] Ignore lib/internal/Magento/Framework/App/Test/Unit/_files/app/etc/en… #39304

m2-assistant bot opened this issue Oct 28, 2024 · 2 comments · May be fixed by #37631
Assignees
Labels
Area: Test framework Component: TestFramework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 28, 2024

This issue is automatically created based on existing pull request: #37631: Ignore lib/internal/Magento/Framework/App/Test/Unit/_files/app/etc/en…


…v.php that gets generated by running unit tests

Description (*)

When running Magento Framework unit tests on your local, one of the tests (don't ask me which one) generates a file: lib/internal/Magento/Framework/App/Test/Unit/_files/app/etc/env.php
So I think we should ignore this file in git.

Related Pull Requests

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

  1. Clone this repo
  2. Check that your git status isn't dirty
  3. Run vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist lib/internal/Magento/Framework/
  4. When it's finished, check your git status again
  5. Expected is that it's still not dirty, but before this PR, it will show a new file found: lib/internal/Magento/Framework/App/Test/Unit/_files/app/etc/env.php

Questions or comments

In my opinion, it's not needed to run automatic tests on this PR, as it shouldn't affect anything besides local developer experience...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 28, 2024
@engcom-Dash engcom-Dash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: TestFramework Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Test framework labels Oct 28, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13293 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Oct 28, 2024

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Test framework Component: TestFramework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants