[Issue] Revert change from 42577bc that introduced side effect in ConfigurableWYSIWYGValidator, function validateConfigured() #39459
Labels
Area: Framework
Component: Framework/Wysiwyg
Issue: Confirmed
Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed
Priority: P2
A defect with this priority could have functionality issues which are not to expectations.
Progress: PR in progress
Reported on 2.4.x
Indicates original Magento version for the Issue report.
Reproduced on 2.4.x
The issue has been reproduced on latest 2.4-develop branch
Triage: Dev.Experience
Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
This issue is automatically created based on existing pull request: #39444: Revert change from 42577bc that introduced side effect in ConfigurableWYSIWYGValidator, function validateConfigured()
Description (*)
Commit 42577bc introduced a side effect in
validateConfigured()
function ofConfigurableWYSIWYGValidator
class.validateConfigured()
function now permanently modifiesallowedTags
property with adding/merging['body', 'html']
to the list of allowed tags on each invocation. This results in an ever growing list of allowed tags for the lifetime of the object of classConfigurableWYSIWYGValidator
.This hit us really hard since we have some long running PHP processes, that go trough HTML validation, calling
validateConfigured()
hundred of thousand of times. In the process,allowedTags
list grew huge, with an ever increasing size. We saw out PHP process worked increasingly more slow with CPU being at 100% all the time.Related Pull Requests
Unknown.
Fixed Issues (if relevant)
No reported issue found.
Manual testing scenarios (*)
validateConfigured()
multiple times. It will run increasingly more slowly.Questions or comments
No Questions
Contribution checklist (*)
The text was updated successfully, but these errors were encountered: