Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media gallery displays incorrect images from directories with identical names but different case #39382

Open
1 of 5 tasks
bhushan-cs opened this issue Nov 19, 2024 · 17 comments · May be fixed by #39502
Open
1 of 5 tasks
Assignees
Labels
Area: Content Component: MediaGallery Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@bhushan-cs
Copy link

Preconditions and environment

  1. Magento 2.4.7

Steps to reproduce

  1. Create folder "Testing"
  2. Upload file "logo.png" to "Testing" folder
  3. Create folder "testing"
  4. "logo.png" file will show in "testing" folder

Expected result

When a file is uploaded to a specific directory, it should only be accessible within that directory. In this case, the "logo.png" file should be exclusively visible within the "Testing" directory.

Actual result

The "logo.png" file is incorrectly displayed within the "testing" directory as well, despite the difference in case. This behavior is unexpected and inconsistent with standard file system behavior.

Additional information

The SQL request that displays the files in media gallery is case insensitive.
Modifying collection query at Magento\MediaGalleryUi\Model\SearchCriteria\CollectionProcessor\FilterProcessor\Directory
$collection->getSelect()->where('path REGEXP ? ', '^' . $value . '/[^\/]*$');
to
$collection->getSelect()->where('BINARY path REGEXP ? ', '^' . $value . '/[^\/]*$');
should fix the issue.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Nov 19, 2024

Hi @bhushan-cs. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Nov 19, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7 Indicates original Magento version for the Issue report. label Nov 19, 2024
@engcom-Bravo
Copy link
Contributor

Hi @bhushan-cs,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the attached video.

Screen.Recording.2024-11-20.at.09.34.32.mov

The "logo.png" file was exclusively visible within the "Testing" directory.

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Nov 20, 2024
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Nov 20, 2024
@hostep
Copy link
Contributor

hostep commented Nov 20, 2024

@engcom-Bravo: have you tested this on a Linux operating system, or on macOS or Windows? Because the latter 2 use a filesystem that by default is case insensitive and Linux normally uses filesystems that are case sensitive. That might explain why you can't reproduce it. So please make sure you test this on a system with a case sensitive filesystem.

@bhushan-cs
Copy link
Author

Hi @engcom-Bravo,

The steps are same as I provided in the report. I didn't get the "could not create directories" error on my instance when creating the directory without case.
I recheck the issue in Latest 2.4-develop instance, it is reproducible. Please refer to the attached video.

magento24dev.2024-11-20.13-40.mp4

My instance details:
OS name: Ubuntu 20.04.6 LTS
Server version: Apache/2.4.41 (Ubuntu)
Server built: 2024-07-17T18:58:09
PHP 8.2.25

The issue is also present in a couple of our live instances, so I think this is not an isolated occurrence. If required, I can provide the server service versions as well.

Please let me know if I can provide any other information for the issue verification process.

Thanks.

@engcom-Delta
Copy link
Contributor

Hi @bhushan-cs ,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is not reproducible. Kindly refer the attached screenshot.

Steps to reproduce

  1. Navigate to Content > Media Gallery
  2. Create a folder under wysiwyg "Testing"
  3. Upload an image in the newly created folder.
  4. Select wysiwyg folder and try to create another folder named "testing"
  5. Observe error displays
    image

Thanks.

@bhushan-cs
Copy link
Author

Hi @engcom-Delta,

Thanks for trying to recreate the issue.

Can you please confirm which OS you are using in your test instance? It's plausible, as @hostep also mentioned, that the OS might be playing a part in this issue.

I have confirmed that my issue is reproducible on my local Ubuntu and live Debian system, and since both are listed as a supported OS in Magento 2 system requirements, can you please try recreating the issue on the same if you haven't yet?

Thanks.

@hostep
Copy link
Contributor

hostep commented Dec 9, 2024

I agree with @bhushan-cs

@engcom-Delta: your video shows you are using macOS, which by default uses a case-insensitive filesystem.
You should try to reproduce this issue on a filesystem that is case-sensitive.
So either reformat your partition/volume as APFS (Case-sensitive) (which as a Magento developer on macOS you should definitively do in my opinion, I've been doing this for 12 years like that), or switch to Linux.

@engcom-Delta
Copy link
Contributor

Hi @bhushan-cs @hostep ,

Thanks for your reporting and collaboration.
We have verified the issue in Latest 2.4-develop instance and the issue is reproducible. Kindly refer the screenshots.
Earlier tests were run in Mac and Windows OS.

Steps to reproduce

  1. OS - Ubuntu
  2. Navigate to Content > Media Gallery
  3. Create a folder under wysiwyg "Testing"
  4. Upload an image in the newly created folder.
  5. Select wysiwyg folder and try to create another folder named "testing"
  6. Observe error displays
    image

Thanks.

@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: MediaGallery Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Content and removed Issue: needs update Additional information is require, waiting for response labels Dec 10, 2024
@m2-community-project m2-community-project bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 10, 2024
@m2-community-project m2-community-project bot added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 10, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13489 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Dec 10, 2024

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot
Copy link

❌ You don't have permission to export this issue.

@engcom-Bravo engcom-Bravo moved this from Needs Update to Confirmed in Issue Confirmation and Triage Board Dec 10, 2024
@engcom-Bravo engcom-Bravo removed their assignment Dec 10, 2024
@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 17, 2024
@bhushan-cs
Copy link
Author

@magento I am working on this

Copy link

m2-assistant bot commented Dec 21, 2024

Hi @bhushan-cs! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@bhushan-cs
Copy link
Author

@magento add to contributors team

Copy link

m2-assistant bot commented Dec 21, 2024

Hi @bhushan-cs! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@bhushan-cs
Copy link
Author

@magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Content Component: MediaGallery Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.7 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
6 participants