\Magento\Quote\Model\QuoteManagement::createEmptyCartForCustomer return not Empty Cart

[ytorbyk]

There is expected to receive an empty Cart (or Quote) due calling "createEmptyCartForCustomer" method. It says the method name. But it's not always true.

Preconditions (*)

Magento 2.4-develop

Steps to reproduce (*)

1. Call the API method /V1/customers/:customerId/carts
   <route url="/V1/customers/:customerId/carts" method="POST"> <service class="Magento\Quote\Api\CartManagementInterface" method="createEmptyCartForCustomer"/> <resources> <resource ref="Magento_Cart::manage" /> </resources> </route>
2. Notice response (in my case 2)
   
3. Send request again
4. Check response

Expected result (*)

1. The really new empty cart (quote) will be created and returned. All further changes applied to the cart will not impact the customer on the front-end.

Actual result (*)

1. The method returns current active quote. If you change the cart it will change cart of the logged in customer.
   

[SerhiyShkolyarenko]

Sorry Yuriy, that expected result is wrong in case of Magento. Our user has only one active cart, if admin resets that cart from API, user will see empty cart on frontend.

[SerhiyShkolyarenko]

To create order not impacting current user's cart you may utilize Sales module service:
<route url="/V1/orders/create" method="PUT"> <service class="Magento\Sales\Api\OrderRepositoryInterface" method="save"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> </route>
It requires huge amount of data, but creates order in one step.

[SerhiyShkolyarenko]

Created internal issue MAGETWO-58190 for updating annotation for createEmptyCartForCustomer() and creating new service supporting old behavior: create new cart for customer and leave it inactive.
Thank you for the report.

[duffner]

@SerhiyShkolyarenko , I believe Yurii to be correct. The intent of this method is to return a quote from the "quote" table with the column "is_active" boolean set to "0". Preparing a quote object for conversion to a transaction via API or other external methods should be able to bypass the current active session. This is a feature of Magento 1, and all Magento 1 features were to be included with Magento 2 this is not an annotation issue, this is missing / not completed functionality. @benmarks, I'd like to involve you in this issue / broken / missing feature. This is a major issue for any customers who want to be able to create an order for a customer, without deleting their existing cart, I'm hoping you can see that this major Enterprise feature is not lost in Magento 2.

[duffner]

@SerhiyShkolyarenko, I am aware of the <route url="/V1/orders/create" method="PUT"> <service class="Magento\Sales\Api\OrderRepositoryInterface" method="save"/> <resources> <resource ref="Magento_Sales::sales" /> </resources> </route> However, creating an order directly doesn't always make sense as you may need to manipulate the object prior to an order.

[SerhiyShkolyarenko]

@duffner thank you for explanation. In Magento 1 that was undocumented feature and in services we lost it. Now we promoted priority of MAGETWO-58190 in order to restore that lost feature and fix our docs.

[duffner]

@SerhiyShkolyarenko thank you!!

[magento-engcom-team]

@ytorbyk, thank you for your report.
We've created internal ticket(s) MAGETWO-58190 to track progress on the issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Thank you for your contributions.

[duffner]

Team,
This is still a valid issue. While I understand it's stale, it's still wrong :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[ytorbyk]

What activity is required here? Please, work on it.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

[duffner]

Just because I'm thinking about a 7-year-old issue, maybe I should see if it can get some love :). This is still a valid issue "createEmptyCartForCustomer" does not return an empty cart, nor does it always create.