-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad ukrainian character encoding in minicart when Enabled JavaScript Bundling in production mode #6733
Comments
@yumicom thank you for your feedback. |
I translated several phrases in different files, for example "Go to Checkout" > "Оформити замовлення" in Magento_Checkout/web/template/minicart/content.html |
Hi! Why don't you use csv files for translation or inline translates? I was able to translate mentioned phrase and deployed bundled js without errors if translate using csv. |
I use csv file )), but not all phrases can be translated in such a way, it is a known Magento bug, maybe it will be fix in version 2.2 |
I know problem about cache and local storage that need to be cleared after deployment. If you mean these problems I will link this ticket to internal. |
Problem in bad characters encoding, in production mode when Enabled JavaScript Bundling. I must to use code converter. |
Do you use any other options for js files like minify or merge? As with only bundling enabled everything is fine. |
I try to use other options for js files: minify and merge - no problems with encoding. Bad character encoding only in bundling enabled |
@yumicom, please provide exact setting of your configuration as we can't reproduce the issue with only js bundling on |
My core_config_data.sql |
Is there already a fix for this issue? I have exactly the same issue as Yumicom is having. For example : |
Polish language has the same issue. |
Internal ticket to track issue progress: MAGETWO-71647 |
@yumicom, thank you for your report. |
Any update on this? Or maybe a reference to the commit for an extension? Would help me a great deal! |
@luckyduck |
Awesome, thank you so much @vil11 ! |
Is this fix available for 2.1.8 ? |
Hi @engcom-backlog-nazar. Thank you for working on this issue.
|
Hi @yumicom The issue was re-tested and we can confirm that it was fixed on the 2.3 release branch. We closing this issue as fixed due to upcoming 2.3 release that will be available soon. |
Preconditions
Steps to reproduce
Actual result
In developer mode good, but in production mode when Enabled JavaScript Bundling I see bad characters in minicart, other characters on all pages are good.
Cache cleaned, magento setup:static-content:deploy command run.
The text was updated successfully, but these errors were encountered: