Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad ukrainian character encoding in minicart when Enabled JavaScript Bundling in production mode #6733

Closed
yumicom opened this issue Sep 23, 2016 · 20 comments
Labels
Area: Frontend bug report Component: Translation Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@yumicom
Copy link

yumicom commented Sep 23, 2016

Preconditions

  1. Magento ver. 2.1.1
  2. php version 7.0, MariaDB 10.1

Steps to reproduce

  1. I manually translated into Ukrainian some phrases in minicart in file: /app/design/frontend/My/Met1/Magento_Checkout/web/template/minicart/content.html , utf-8 without boom.

Actual result

In developer mode good, but in production mode when Enabled JavaScript Bundling I see bad characters in minicart, other characters on all pages are good.
Cache cleaned, magento setup:static-content:deploy command run.

@veloraven
Copy link
Contributor

@yumicom thank you for your feedback.
Could you please provide exact phrases you translated?

@yumicom
Copy link
Author

yumicom commented Sep 26, 2016

I translated several phrases in different files, for example "Go to Checkout" > "Оформити замовлення" in Magento_Checkout/web/template/minicart/content.html
I found a temporary solution to encode Ukrainian phrases for JavaScript: "Оформити замовлення" > "\u041E\u0444\u043E\u0440\u043C\u0438\u0442\u0438 \u0437\u0430\u043C\u043E\u0432\u043B\u0435\u043D\u043D\u044F"

@sevos1984
Copy link
Contributor

sevos1984 commented Sep 26, 2016

Hi! Why don't you use csv files for translation or inline translates? I was able to translate mentioned phrase and deployed bundled js without errors if translate using csv.

@yumicom
Copy link
Author

yumicom commented Sep 26, 2016

I use csv file )), but not all phrases can be translated in such a way, it is a known Magento bug, maybe it will be fix in version 2.2

@duhon duhon removed their assignment Sep 26, 2016
@sevos1984
Copy link
Contributor

I know problem about cache and local storage that need to be cleared after deployment. If you mean these problems I will link this ticket to internal.

@yumicom
Copy link
Author

yumicom commented Sep 29, 2016

Problem in bad characters encoding, in production mode when Enabled JavaScript Bundling. I must to use code converter.

@sevos1984
Copy link
Contributor

Do you use any other options for js files like minify or merge? As with only bundling enabled everything is fine.

@yumicom
Copy link
Author

yumicom commented Sep 30, 2016

I try to use other options for js files: minify and merge - no problems with encoding. Bad character encoding only in bundling enabled

@tkacheva
Copy link

@yumicom, please provide exact setting of your configuration as we can't reproduce the issue with only js bundling on

@yumicom
Copy link
Author

yumicom commented Oct 17, 2016

My core_config_data.sql
core_config_data.zip

@mvmenno
Copy link

mvmenno commented Jan 25, 2017

Is there already a fix for this issue? I have exactly the same issue as Yumicom is having.
I use 2.0.11 and i am deploying to the french language.
This isue seems to be only happening if phrases are translated in the js-translation.json file.
In developer mode it works just fine but deploying using production mode breaks the encoding.

For example :
"Extraatje voor de \u00e9chte klusser":"Un petit plus pour nos bricoleur"

@maqlec
Copy link
Contributor

maqlec commented Mar 22, 2017

Polish language has the same issue.

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-71647

@magento-team magento-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Area: Frontend labels Sep 1, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Area: Frontend Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Component: Translation labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@yumicom, thank you for your report.
The issue is already fixed in develop branch
But we will consider to backport the fix to patch releases

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 20, 2017
@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Nov 20, 2017
@luckyduck
Copy link

Any update on this? Or maybe a reference to the commit for an extension? Would help me a great deal!

@vil11
Copy link

vil11 commented Feb 2, 2018

@luckyduck
Initial issue is fixed (MAGETWO-71647) & delivered in #10563 for 2.3.0.

@luckyduck
Copy link

Awesome, thank you so much @vil11 !

@okorshenko okorshenko added the Event: distributed-cd Distributed Contribution Day label Mar 2, 2018
@grazianodimaio
Copy link

Is this fix available for 2.1.8 ?

@ishakhsuvarov ishakhsuvarov added ready for backport and removed Event: distributed-cd Distributed Contribution Day labels Apr 13, 2018
@ghost ghost self-assigned this Nov 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-nazar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost
Copy link

ghost commented Nov 14, 2018

Hi @yumicom The issue was re-tested and we can confirm that it was fixed on the 2.3 release branch. We closing this issue as fixed due to upcoming 2.3 release that will be available soon.

@ghost ghost closed this as completed Nov 14, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend bug report Component: Translation Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

No branches or pull requests