-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text swatch "zero" not shown #7673
Comments
Created internal issue MAGETWO-61828 to investigate and track this issue. |
@wert2all, we found a solution to this. Originally in /module-swatches/Helper/Data.php on line 412 there is a IF statement thats checking $item['value'] and it checks the value like this: elseif ($item['store_id'] == $currentStoreId && $item['value']) I think it should be: elseif ($item['store_id'] == $currentStoreId && $item['value'] != '') Cause when our swatch value is "0" (zero) it thinks that the second value ($item['value']) is FALSE (zero) |
Hi @imgali please fell free to create PR for this |
This appears to still be an issue in 2.1.5 |
@thecrazyrussian I made a pull request already and it was approved. Just use quick fix from @imgali message for now. |
Thank you @oroskodias |
Steps to reproduce
Expected result
Actual result
The text was updated successfully, but these errors were encountered: