Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint mistake in english language #8958

Closed
JDThralls opened this issue Mar 21, 2017 · 7 comments
Closed

Hint mistake in english language #8958

JDThralls opened this issue Mar 21, 2017 · 7 comments
Assignees
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@JDThralls
Copy link

JDThralls commented Mar 21, 2017

Preconditions

  1. Magento 2.1.5 (downloaded from official website with timestamp 2017-02-20)
  2. PHP 7 on Apache dedicated server (does not actually matter)

Steps to reproduce

  1. Logged in to admin panel
  2. Content -> Configuration
  3. Global configuration hint is shown as follows in english:

Actual result

"Search strings are either normal strings or regular exceptions (PCRE)."

Expected result

"Search strings are either normal strings or regular expressions (PCRE)."

@JDThralls
Copy link
Author

This mistake is in the documentation as well:

Example:
http://devdocs.magento.com/guides/v2.1/frontend-dev-guide/themes/theme-apply.html
Under "Add A Design Exception"
"In the Search String box specify the user-agent using either normal strings or regular exceptions (PCRE). In the Theme Name drop-down list select the theme to be used for matching agent."
where it should say
"In the Search String box specify the user-agent using either normal strings or regular expressions (PCRE). In the Theme Name drop-down list select the theme to be used for matching agent."

@mbrinton01
Copy link

Thank you @MighT-W315H31T for catching this. Would you be able to create a PR to fix? We also accept PRs for docs: http://devdocs.magento.com/guides/v2.1/contributor-guide/contributing_docs.html

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 11, 2017
@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Oct 1, 2017
@magento-engcom-team
Copy link
Contributor

@MighT-W315H31T, thank you for your report.
We've created internal ticket(s) MAGETWO-80537 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 2, 2017
@jahvi
Copy link

jahvi commented Oct 11, 2017

Just wanted to give this one a go with #11390, I also submitted a PR to fix the docs with magento/devdocs#1450

@magento-engcom-team
Copy link
Contributor

Hi @MighT-W315H31T the issue has been fixed in 2.2-develop branch and will be available with release 2.2.1 soon.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 12, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81679

@magento-team
Copy link
Contributor

Hi @MighT-W315H31T. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1282 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants