Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

South Korea Zip Code Validation incorrect #9515

Closed
wigman opened this issue May 4, 2017 · 4 comments
Closed

South Korea Zip Code Validation incorrect #9515

wigman opened this issue May 4, 2017 · 4 comments
Assignees
Labels
bug report Component: Checkout Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@wigman
Copy link
Contributor

wigman commented May 4, 2017

Issue

Zip code validation fails on adresses from South Korea since it validates against deprecated format.
Current validation is 123-456. This should be 12345.

"Postal codes in South Korea are 5-digit numeric, whose system newly introduced in August 1, 2015." (https://en.wikipedia.org/wiki/List_of_postal_codes_in_South_Korea)

Preconditions

On all 2.* versions including development branch.

Steps to reproduce

go to cart or checkout, select South Korea and insert postal code 12345

Expected result

Validation should succeed.

Actual result

Validation fails

Solution

Replace:
<zip countryCode="KR"> <codes> <code id="pattern_1" active="true" example="123-456">^[0-9]{3}-[0-9]{3}$</code> </codes> </zip>
With:
<zip countryCode="KR"> <codes> <code id="pattern_1" active="true" example="12345">^[0-9]{5}$</code> </codes> </zip>
OR add it as a second pattern (for backwards compatibility ?)

in /app/code/Magento/Directory/etc/zip_codes.xml

@VasylShvorak
Copy link
Contributor

@wigman Thanks for reporting this issue. Created internal issue MAGETWO-70281 to investigate and track this issue.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 27, 2017
@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Checkout Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team
Copy link
Contributor

@wigman, thank you for your report.
We've created internal ticket(s) MAGETWO-70281 to track progress on the issue.

@EmilyPepperman
Copy link
Contributor

I have this same issue. Just had a new South Korean customer try and place an order.

@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 11, 2017
@RomaKis RomaKis self-assigned this Nov 22, 2017
@okorshenko
Copy link
Contributor

The issue has been fixed and delivered to 2.2-develop branch

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Checkout Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

7 participants