Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wysiwyg Editor Image Upload Doesn't Work Second Time #9597

Closed
bydrei opened this issue May 11, 2017 · 5 comments
Closed

Wysiwyg Editor Image Upload Doesn't Work Second Time #9597

bydrei opened this issue May 11, 2017 · 5 comments
Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@bydrei
Copy link

bydrei commented May 11, 2017

Preconditions

  1. Magento Version EE 2.1.5
  2. Theme based of blank.

Steps to reproduce

  1. Login to admin panel
  2. Go to Content - Pages
  3. Edit any page then click on "Show / Hide Editor" to go to the plain editor.
  4. Click on Insert Image, let the GUI load, then click the X to close.
  5. Click on Insert Image again (here you won't be able to open the popup again)

Expected result

  1. You should be able to close and open as many times you want and need.

Actual result

  1. Uncaught TypeError: Cannot read property 'closed' of undefined at Object.openDialog (browser.js:39) at HTMLButtonElement.onclick ((index):1)
@bydrei bydrei changed the title Wysiwyg Editor Image Upload Doesn't Work Second Wysiwyg Editor Image Upload Doesn't Work Second Tome May 11, 2017
@bydrei bydrei changed the title Wysiwyg Editor Image Upload Doesn't Work Second Tome Wysiwyg Editor Image Upload Doesn't Work Second Time May 11, 2017
@KevinGimbel
Copy link

Can confirm this is the case for Magento CE 2.1.6. It also does not work after inserting an image (e.g not closing the overlay with X).

I am also not able to switch to the WYSIWYG Editor from the plain editor.

@hostep
Copy link
Contributor

hostep commented May 15, 2017

This was already fixed on the develop branch almost a year ago, but wasn't being backported. So I did just that and created a backport for this fix to apply on Magento 2.1.x: #9332 and it was approved!
I hope it will make its way into the next 2.1.x release :)

@vincentwinkel
Copy link

vincentwinkel commented Jul 3, 2017

Hi,
I don't know if it's the same problem, but tested on several personal 2.0.14 install and testable on this 2.0.7 demo online : http://magento2.demo.ubertheme.com/admin (uber / uber123).

  1. Create a new CMS page
  2. Insert an image (open popup + choose an image + validate) : the popup is closed, the image is inserted
  3. Insert a new image (open popup + choose an image + validate) : the popup is closed but the overlay is still here and no image is inserted

screen shot 2017-07-03 at 11 01 32

Do I need to create a new ticket ? I don't find solution neither similar ticket except this one.

@magento-engcom-team magento-engcom-team added G1 Passed bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 28, 2017
@magento-engcom-team
Copy link
Contributor

@ferrazzuk, thank you for your report.
The issue is already fixed in develop branch, 2.2.0, 2.1.9

@vincentwinkel
Copy link

What about magento 2.0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

6 participants