Skip to content

X-Magento-Tags contains identifiers from removed blocks #9779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kassner opened this issue May 29, 2017 · 2 comments
Closed

X-Magento-Tags contains identifiers from removed blocks #9779

kassner opened this issue May 29, 2017 · 2 comments
Assignees
Labels
bug report Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Progress: needs update

Comments

@kassner
Copy link
Contributor

kassner commented May 29, 2017

Following the investigation and fix of #5897, I noticed that Magento\PageCache\Model\Layout\LayoutPlugin::afterGetOutput sets tags for the related products (i.e.: cat_p_123), even if the related products block is not rendered.

Preconditions

  1. Current Magento develop (8e21d5a);

Steps to reproduce

  1. Setup as explained in FPC: Upsells & Related product list bug - getIdentities gets called while the block doesn't render and then crashes #5897;
  2. Debug headers using varnishlog and navigate to the configurable product ('Product 3' or 'Product 4' as the bug report above);

Expected result

  1. X-Magento-Tags will not contain cat_p_123 (given that 123 is the ID of the related product);

Actual result

  1. X-Magento-Tags contains cat_p_123 (given that 123 is the ID of the related product);
@magento-engcom-team magento-engcom-team added bug report develop Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 20, 2017
@magento-engcom-team
Copy link
Contributor

@kassner Thanks for reporting this issue.
Unfortunately, I could not reproduce the issue as you described it. Please add more details to your description of the steps you followed when identifying this issue. Screenshots or logs would be helpful, too.

@magento-engcom-team magento-engcom-team self-assigned this Sep 26, 2017
@magento-engcom-team magento-engcom-team added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update labels Sep 26, 2017
@magento-engcom-team
Copy link
Contributor

@kassner, we are closing this issue due to inactivity. If you'd like to update it, please reopen the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Progress: needs update
Projects
None yet
Development

No branches or pull requests

3 participants