Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of MAGETWO-69379 for Magento 2.1: use payment method name to… #13543

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Backport of MAGETWO-69379 for Magento 2.1: use payment method name to… #13543

merged 1 commit into from
Feb 21, 2018

Conversation

hostep
Copy link
Contributor

@hostep hostep commented Feb 7, 2018

… make checkbox of agreements more unique #6207 #9717

(cherry picked from commit 14b9b98)

Description

This is a backport of MAGETWO-69379 for Magento 2.1 (see #9717)

Fixed Issues (if relevant)

  1. Checkbox IDs for Terms and Conditions should be unique in Checkout #6207: Checkbox IDs for Terms and Conditions should be unique in Checkout

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov @hostep
Backport of MAGETWO-69379 for Magento 2.1: use payment method name to…
6ec9e22 
… make checkbox of agreements more unique magento#6207 magento#9717

(cherry picked from commit 14b9b98)
@miguelbalparda miguelbalparda self-assigned this Feb 12, 2018
@miguelbalparda miguelbalparda added this to the February 2018 milestone Feb 12, 2018
@Rekha-periasamy Rekha-periasamy mentioned this pull request Feb 20, 2018
Closed
@Rekha-periasamy
Copy link

I have tried to apply #13543 and #6207 patch file for fixing the terms and conditions issue in web shop. Still I'm facing issue.

Steps to reproduce:

Enable check money order and Paypal

In checkout page check the check/money order payment method checkbox and go to Paypal payment method then hit the place order button. The expected behavior should be throw the validation message in Paypal payment section while hitting the place order button. Here it's allowing to proceed the payment.
Kindly do the needful. It's pretty urgent.

@magento-engcom-team magento-engcom-team merged commit 6ec9e22 into magento:2.1-develop Feb 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Feb 21, 2018
MAGETWO-87745: Backport of MAGETWO-69379 for Magento 2.1: use payment…
785b207 
… method name to… #13543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miguelbalparda miguelbalparda

Labels
Progress: accept Release Line: 2.1
Projects
None yet
Milestone
February 2018
Development

Successfully merging this pull request may close these issues.
5 participants
@hostep @Rekha-periasamy @miguelbalparda @magento-engcom-team @ishakhsuvarov