Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: A window size hook! #1192

Closed
1 of 6 tasks
sirugh opened this issue May 2, 2019 · 0 comments · Fixed by #1193
Closed
1 of 6 tasks

[feature]: A window size hook! #1192

sirugh opened this issue May 2, 2019 · 0 comments · Fixed by #1193
Assignees
Labels
enhancement New feature or request

Comments

@sirugh
Copy link
Contributor

sirugh commented May 2, 2019

Is your feature request related to a problem? Please describe.
Components (like Thumbnail) may want to do something when the window size changes such as make a new determination whether to render or not.

Describe the solution you'd like
Implement a window size hook!

Describe alternatives you've considered
We can also implement this as multiple hooks for height and width but that's probably overkill

Additional context
https://codesandbox.io/s/qz590jkzv6

Please let us know what packages this feature is in regards to:

  • venia-concept
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant