Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all Public API components to Storybook #1578

Closed
supernova-at opened this issue Aug 19, 2019 · 2 comments
Closed

Add all Public API components to Storybook #1578

supernova-at opened this issue Aug 19, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@supernova-at
Copy link
Contributor

Currently Venia UI's Storybook only has a handful of components available:

  1. Image
  2. Header
  3. MiniCart
  4. SearchBar
  5. ToastContainer
  6. Braintree Dropin

Since all of the components in Venia UI are considered part of our Public API, we should expect partners to be using them and therefore we should add them to our Storybook.

@supernova-at supernova-at added the enhancement New feature or request label Aug 19, 2019
@sirugh
Copy link
Contributor

sirugh commented Aug 23, 2019

I think we should turn this into a milestone and then create issues for each of the components missing storybook. Then it's easily trackable and it has a nice pretty progress bar for people who care about nice pretty progress bars :D

@supernova-at
Copy link
Contributor Author

Internal core epic PWA-1031 covers Storybook improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants